Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to release/dev17.9 #16433

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from main into release/dev17.9.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-release/dev17.9
git reset --hard upstream/release/dev17.9
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-release/dev17.9 --force

dawedawe and others added 2 commits December 13, 2023 18:31
…16373)

* allow the TailCall attribute to be defined outside of FSharp.Core by just checking the CompiledName to be "TailCallAttribute"

* check the FullName to make sure it's in the FSharp.Core namespace

* add changelog entry

* add PR number to changelog entry

* - remove member attrib_TailCallAttribute from TcGlobals
- move hasTailCallAttrib from TailCallChecks.fs to TcGlobals

* Update tests/FSharp.Compiler.ComponentTests/ErrorMessages/TailCallAttribute.fs

Co-authored-by: Petr <psfinaki@users.noreply.github.com>

* remote "withLangVersionPreview" from test for self-defined attribute

* add sample project to demonstrate

---------

Co-authored-by: Petr <psfinaki@users.noreply.github.com>
#16411)

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231207.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.23565.2 -> To Version 9.0.0-alpha.1.23607.1

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231208.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.23565.2 -> To Version 9.0.0-alpha.1.23608.1

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231208.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.23565.2 -> To Version 9.0.0-alpha.1.23608.1

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231208.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.23565.2 -> To Version 9.0.0-alpha.1.23608.1

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231211.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.23565.2 -> To Version 9.0.0-alpha.1.23611.3

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231211.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.23565.2 -> To Version 9.0.0-alpha.1.23611.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
@KevinRansom KevinRansom merged commit 2aefcec into release/dev17.9 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants