Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness-related aggressive trimming of FSharp.Core #16387

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Nullness-related aggressive trimming of FSharp.Core #16387

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
755a54d
nullness-related aggressive trimming of FSharp.Core
T-Gro Dec 5, 2023
abdcb0e
decreasing size thanks to new settings
T-Gro Dec 5, 2023
e2967d7
Simplify trimcheck, compressed and normal should be the same
T-Gro Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/AheadOfTime/Trimming/check.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function CheckTrim($root, $tfm, $outputfile, $expected_len) {
# NOTE: Trimming now errors out on desktop TFMs, as shown below:
# error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher.
$compressAllMetadata = $env:_kind -eq "-compressAllMetadata"
$expectedForSelfContained = if ($compressAllMetadata) {300032} else {288256}
$expectedForSelfContained = if ($compressAllMetadata) {288256} else {288256}
Copy link
Contributor

@kerams kerams Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What metadata does the compression refer to? If it's sigdata and optdata, does this flag and CI step make sense if they are removed during trimming, which the equal on/off sizes would indicate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.
Now that I removed rest of the metadata (incl. the nullness ones), I can remove this conditional logic alltogether and just keep a single size.

(will probably keep the two CI runs to catch for regressions when .e.g a a new resource is introduced)


# Check net7.0 trimmed assemblies
CheckTrim -root "SelfContained_Trimming_Test" -tfm "net8.0" -outputfile "FSharp.Core.dll" -expected_len $expectedForSelfContained
Expand Down