Allow merging of Namespace and Module in TrieMapping #16070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Oct 3, 2023
|
I spoke with Janusz earlier this week, and he's planning to review it within this week. If you haven't received any updates by next week, I suggest merging it as-is. We can handle any feedback at a later stage. |
safesparrow
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
This fixes the issue, so happy for it to be merged. Thanks @nojaf
Longer term we might want to refactor the model to more accurately represent the language constructs, but that's not a blocker in any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15985.
@safesparrow would you mind taking a look at this change?
The problem was in constructing the Trie. We didn't anticipate that a name could be used for both a module and a namespace. My fix is to treat the module as it exposes a type inside the namespace.
I think this is acceptable but would like to hear your opinion here.