Remove 'Capture identifiers when parsing' setting from VS options

vsintegration/src/FSharp.Editor/FSharp.Editor.resx

@@ -211,7 +211,7 @@ Time until stale results are used (in milliseconds);
 Parallelization (requires restart);
 Enable parallel type checking with signature files;
 Enable parallel reference resolution;
-Enable fast find references & rename (experimental);
+Enable fast find references & rename (restart required);
 Cache parsing results (experimental)</value>
   </data>
   <data name="6012" xml:space="preserve">

vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs

@@ -145,10 +145,6 @@ type internal FSharpWorkspaceServiceFactory [<Composition.ImportingConstructor>]
                             let enableBackgroundItemKeyStoreAndSemanticClassification =
                                 editorOptions.LanguageServicePerformance.EnableBackgroundItemKeyStoreAndSemanticClassification
 
-                            // Default should be true
-                            let captureIdentifiersWhenParsing =
-                                editorOptions.LanguageServicePerformance.CaptureIdentifiersWhenParsing
-
                             // Default is false here
                             let solutionCrawler = editorOptions.Advanced.SolutionBackgroundAnalysis
 
@@ -169,7 +165,7 @@ type internal FSharpWorkspaceServiceFactory [<Composition.ImportingConstructor>]
                                         nameof keepAllBackgroundSymbolUses, keepAllBackgroundSymbolUses
                                         nameof enableBackgroundItemKeyStoreAndSemanticClassification,
                                         enableBackgroundItemKeyStoreAndSemanticClassification
-                                        nameof captureIdentifiersWhenParsing, captureIdentifiersWhenParsing
+                                        "captureIdentifiersWhenParsing", enableFastFindReferences
                                         nameof solutionCrawler, solutionCrawler
                                     |],
                                     TelemetryThrottlingStrategy.NoThrottling
@@ -186,7 +182,7 @@ type internal FSharpWorkspaceServiceFactory [<Composition.ImportingConstructor>]
                                         enableBackgroundItemKeyStoreAndSemanticClassification,
                                     enablePartialTypeChecking = enablePartialTypeChecking,
                                     parallelReferenceResolution = enableParallelReferenceResolution,
-                                    captureIdentifiersWhenParsing = captureIdentifiersWhenParsing,
+                                    captureIdentifiersWhenParsing = enableFastFindReferences,
                                     documentSource =
                                         (if enableLiveBuffers then
                                              DocumentSource.Custom getSource

vsintegration/src/FSharp.Editor/Options/EditorOptions.fs

@@ -88,7 +88,6 @@ type LanguageServicePerformanceOptions =
         KeepAllBackgroundResolutions: bool
         KeepAllBackgroundSymbolUses: bool
         EnableBackgroundItemKeyStoreAndSemanticClassification: bool
-        CaptureIdentifiersWhenParsing: bool
     }
 
     static member Default =
@@ -103,7 +102,6 @@ type LanguageServicePerformanceOptions =
             KeepAllBackgroundResolutions = false
             KeepAllBackgroundSymbolUses = false
             EnableBackgroundItemKeyStoreAndSemanticClassification = true
-            CaptureIdentifiersWhenParsing = true
         }
 
 [<CLIMutable>]

vsintegration/src/FSharp.UIResources/LanguageServicePerformanceOptionControl.xaml

@@ -85,9 +85,6 @@
                         <CheckBox x:Name="enableBackgroundItemKeyStoreAndSemanticClassification"
                                   IsChecked="{Binding EnableBackgroundItemKeyStoreAndSemanticClassification}"
                                   Content="{x:Static local:Strings.Enable_Background_ItemKeyStore_And_Semantic_Classification}"/>
-                        <CheckBox x:Name="captureIdentifiersWhenParsing"
-                                  IsChecked="{Binding CaptureIdentifiersWhenParsing}"
-                                  Content="{x:Static local:Strings.Capture_Identifiers_When_Parsing}"/>                        
                     </StackPanel>
                 </GroupBox>
 

vsintegration/src/FSharp.UIResources/Strings.resx

@@ -249,9 +249,6 @@
   <data name="Enable_Background_ItemKeyStore_And_Semantic_Classification" xml:space="preserve">
     <value>Keep background symbol keys</value>
   </data>
-  <data name="Capture_Identifiers_When_Parsing" xml:space="preserve">
-    <value>Capture identifiers while parsing</value>
-  </data>
   <data name="Enable_Live_Buffers" xml:space="preserve">
     <value>Use live (unsaved) buffers for checking (restart required)</value>
   </data>