Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset FCS versions #11030

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Reset FCS versions #11030

merged 2 commits into from
Feb 6, 2021

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Feb 5, 2021 •
edited
Loading

Prepare to release fcs 39.0.0 --- breaking changes here: b23b2a0

@KevinRansom KevinRansom mentioned this pull request Feb 5, 2021
Closed
@cartermp
Copy link
Contributor

cartermp commented Feb 5, 2021

What's the diff between 38.0.2 and 38.0.3?

cartermp
cartermp suggested changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting up a block for now, is there an actual diff we're releasing? If this includes everything we merged from main, then this needs a major version bump because it incorporate several breaking changes.

@KevinRansom
Copy link
Member Author

@cartermp, what breaks did we introduce to main?

@cartermp
Copy link
Contributor

cartermp commented Feb 6, 2021

I'm looking, i suspect it was @dsyme's huge FCS changes

@KevinRansom
Copy link
Member Author

KevinRansom commented Feb 6, 2021 •
edited
Loading

I'm looking, i suspect it was @dsyme's huge FCS changes

I updated the descriptionwith the commit of the breaks.

@baronfel
Copy link
Member

baronfel commented Feb 6, 2021

This also has the de-async work that Phillip did months ago.

@cartermp
Copy link
Contributor

cartermp commented Feb 6, 2021

No no, that was Don :)

@KevinRansom KevinRansom merged commit 6696fbc into dotnet:release/fcs Feb 6, 2021
@KevinRansom KevinRansom deleted the version branch January 21, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@brettfo brettfo Awaiting requested review from brettfo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinRansom @cartermp @baronfel