add ci step to do a plain dotnet build
#10306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Oct 21, 2020
81ccd84 to
815c890
Compare
|
@brettfo Could it also have a Windows build, in addition to Linux and macOS ones, please? |
|
@auduchinok , it doesn't work on Windows ... I have to make some changes ....: #10151 (comment) |
|
@KevinRansom My suggestion is about having it in CI at least when we have a fix, so it doesn't accidentally get broken again. 🙂 |
|
@auduchinok , when I submit the fix, I will include a ci leg for it :-) |
|
Since I'm already here I added a Windows version that can simply be un-commented when ready. |
|
@brettfo thanks mate. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* add ci step to do a plain `dotnet build` * report installed SDK versions * generate binlogs of each build * add windows build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #10151 I decided it would be a good idea to ensure that
dotnet build ./FSharp.slnalways works following an initial./build.sh.