Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken diagnostic fix usage metric #14456

Closed
Tracked by #15408
psfinaki opened this issue Dec 8, 2022 · 3 comments
Closed
Tracked by #15408

Broken diagnostic fix usage metric #14456

psfinaki opened this issue Dec 8, 2022 · 3 comments
Assignees
@psfinaki
Labels
Bug Theme-Telemetry Telemetry related to the F# features in VS
Milestone
October-2023

Comments

@psfinaki
Copy link
Member

psfinaki commented Dec 8, 2022

F# "Diagnostic Fix Usage" is broken in our telemetry and shows incorrect diagnostic IDs.

Figure out why this is happening and make the metric great again.
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Dec 8, 2022
@github-actions github-actions bot added this to the Backlog milestone Dec 8, 2022
@psfinaki psfinaki added Theme-Telemetry Telemetry related to the F# features in VS and removed Needs-Triage labels Dec 8, 2022
@psfinaki psfinaki mentioned this issue Dec 8, 2022
Closed
@psfinaki psfinaki self-assigned this Dec 8, 2022
@psfinaki psfinaki modified the milestones: Backlog, December-2022 Dec 8, 2022
@psfinaki
Copy link
Member Author

This is likely caused by the problem with the DocumentDiagnosticAnalyzer design mentioned here. For three other analyzers we have proper IDs in telemetry, but in this case, due to the weird dependency flow, we end up with random data most probably via this mechanism.

So this might be fixed along with the fix to the issue above.

@psfinaki psfinaki removed this from the December-2022 milestone Dec 13, 2022
@psfinaki psfinaki added this to the January-2023 milestone Jan 9, 2023
@psfinaki psfinaki removed this from the February-2023 milestone Feb 6, 2023
@psfinaki psfinaki moved this from Not Planned to Planned in F# Compiler and Tooling Apr 6, 2023
@psfinaki psfinaki added this to the April-20203 milestone Apr 6, 2023
@psfinaki
Copy link
Member Author

Should be done with this task: #15059
Currently we have data only for those code fixes which go through CodeFixHelpers module (about two thirds of them).

@vzarytovskii vzarytovskii removed this from the April-2023 milestone May 4, 2023
@psfinaki psfinaki assigned psfinaki and unassigned psfinaki Sep 27, 2023
@psfinaki psfinaki mentioned this issue Sep 27, 2023
Open
85 tasks
@psfinaki psfinaki added this to the September-2023 milestone Sep 27, 2023
@psfinaki
Copy link
Member Author

All the code fixes are unified now, closing this.

@github-project-automation github-project-automation bot moved this from Planned to Done in F# Compiler and Tooling Sep 27, 2023
@psfinaki psfinaki modified the milestones: September-2023, October-2023 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psfinaki psfinaki

Labels
Bug Theme-Telemetry Telemetry related to the F# features in VS
Projects
F# Compiler and Tooling
Archived in project
Milestone
October-2023
Development

No branches or pull requests
2 participants
@vzarytovskii @psfinaki