diff --git a/.gitignore b/.gitignore index 7f3870c3d05..b43741116dc 100644 --- a/.gitignore +++ b/.gitignore @@ -130,3 +130,6 @@ msbuild.binlog /fcs/FSharp.Compiler.Service.netstandard/*.fsi /.ionide/ **/.DS_Store +/tests/fsharp/regression/5531/compilation.output.test.txt +/tests/fsharp/core/fsfromfsviacs/compilation.langversion.old.output.txt +/tests/fsharp/core/fsfromfsviacs/compilation.errors.output.txt diff --git a/src/fsharp/CompileOps.fs b/src/fsharp/CompileOps.fs index 78da786d055..1ae2d315076 100644 --- a/src/fsharp/CompileOps.fs +++ b/src/fsharp/CompileOps.fs @@ -2880,8 +2880,11 @@ type TcConfig private (data: TcConfigBuilder, validate: bool) = [ // Check if we are given an explicit framework root - if so, use that match tcConfig.clrRoot with - | Some x -> - yield tcConfig.MakePathAbsolute x + | Some x -> + let clrRoot = tcConfig.MakePathAbsolute x + yield clrRoot + let clrFacades = Path.Combine(clrRoot, "Facades") + if Directory.Exists(clrFacades) then yield clrFacades | None -> // "there is no really good notion of runtime directory on .NETCore" diff --git a/tests/fsharp/regression/5531/compilation.output.test.txt b/tests/fsharp/regression/5531/compilation.output.test.txt deleted file mode 100644 index 1e22e0e78d5..00000000000 --- a/tests/fsharp/regression/5531/compilation.output.test.txt +++ /dev/null @@ -1,14 +0,0 @@ - -warning FS0082: There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference "mscorlib.dll", "x86". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project. (Code=MSB3270) - -warning FS0082: There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference "System.Data.dll", "x86". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project. (Code=MSB3270) - -warning FS0082: There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference "System.Web.dll", "x86". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project. (Code=MSB3270) - -warning FS0082: There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference "mscorlib.dll", "x86". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project. (Code=MSB3270) - -warning FS0082: There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference "System.Data.dll", "x86". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project. (Code=MSB3270) - -warning FS0082: There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference "System.Web.dll", "x86". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project. (Code=MSB3270) - -test.fs(7,17): warning FS0864: This new member hides the abstract member 'abstract member Base.Foo : unit -> unit'. Rename the member or use 'override' instead.