Skip to content

Commit

Permalink
Remove unnecessary code
Browse files Browse the repository at this point in the history
  • Loading branch information
KevinRansom committed May 17, 2024
1 parent c7eec77 commit 66b8eae
Showing 1 changed file with 6 additions and 15 deletions.
21 changes: 6 additions & 15 deletions src/Compiler/Optimize/Optimizer.fs
Original file line number Diff line number Diff line change
Expand Up @@ -2367,16 +2367,7 @@ let rec OptimizeExpr cenv (env: IncrementalOptimizationEnv) expr =
OptimizeConst cenv env expr (c, m, ty)

| Expr.Val (v, _vFlags, m) ->
if not (v.Accessibility.IsPrivate) then
OptimizeVal cenv env expr (v, m)
else
expr,
{ TotalSize = 10
FunctionSize = 1
HasEffect = false
MightMakeCriticalTailcall=false
Info=UnknownValue }

OptimizeVal cenv env expr (v, m)

| Expr.Quote (ast, splices, isFromQueryExpression, m, ty) ->
let doData data = map3Of4 (List.map (OptimizeExpr cenv env >> fst)) data
Expand Down Expand Up @@ -3086,8 +3077,8 @@ and TryOptimizeVal cenv env (vOpt: ValRef option, shouldInline, inlineIfLambda,
let fvs = freeInExpr CollectLocals expr
if fvs.UsesMethodLocalConstructs then
// Discarding lambda for binding because uses protected members --- TBD: Should we warn or error here
None
elif fvs.FreeLocals |> Seq.exists(fun v -> v.Accessibility.IsPrivate ) then
None
elif fvs.FreeLocals |> Seq.exists(fun v -> v.Accessibility.IsPrivate) then
// Discarding lambda for binding because uses private members --- TBD: Should we warn or error here
None
else
Expand Down Expand Up @@ -4136,18 +4127,18 @@ and OptimizeBinding cenv isRec env (TBind(vref, expr, spBind)) =
// Trim out optimization information for expressions that call protected members
let rec cut ivalue =
match ivalue with
| CurriedLambdaValue (_, arities, size, body, _) ->
| CurriedLambdaValue (_a, arities, size, body, _b) ->
if size > (cenv.settings.lambdaInlineThreshold + arities + 2) then
// Discarding lambda for large binding
UnknownValue
else
let fvs = freeInExpr CollectLocals body
if fvs.UsesMethodLocalConstructs then
// Discarding lambda for binding because uses protected members
UnknownValue
UnknownValue
elif fvs.FreeLocals.ToArray() |> Seq.fold(fun acc v -> if not acc then v.Accessibility.IsPrivate else acc) false then
// Discarding lambda for binding because uses private members
UnknownValue
UnknownValue
else
ivalue

Expand Down

0 comments on commit 66b8eae

Please sign in to comment.