Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 331ae036bed29021d3326c79e2339a7efd95a4b6 breaks testing #1034

Closed
DSANTIMORE opened this issue Apr 4, 2019 · 6 comments
Closed

Commit 331ae036bed29021d3326c79e2339a7efd95a4b6 breaks testing #1034

DSANTIMORE opened this issue Apr 4, 2019 · 6 comments

Comments

@DSANTIMORE
Copy link

331ae03 appears to break the test output file name conventions that used to exist (this is mentioned microsoft/vstest#1876 (comment) as well).

Is there a way to target the before this commit (so, dotnet test 15.9) using tagging of FROM microsoft/dotnet:2.1-sdk

Many thanks for the repy.

@mthalman
Copy link
Member

mthalman commented Apr 4, 2019

@DSANTIMORE - You can unblock yourself while we investigate this by referencing the previous version of the image in this way:
FROM mcr.microsoft.com/dotnet/core/sdk:2.1.505

@DSANTIMORE
Copy link
Author

Thank you for the quick reply. And we've found a way to use wild cards correctly to handle it more elegantly, as well.

@mthalman
Copy link
Member

mthalman commented Apr 4, 2019

@DSANTIMORE - Can you provide details on the actual and expected behaviors you're seeing? From looking at microsoft/vstest#1876, it looks like the only work that has been done so far is to add a timestamp at the end of the user-provided log file name. You're saying that after making use of the latest changes from 331ae03, you're no longer seeing the timestamp automatically added at the end log file name?

@DSANTIMORE
Copy link
Author

@mthalman , my apologies, I didn't write up a very good summary. The breaking behavior was the addition of the timestamp.

I think your tag note above is a sufficient answer for me; basically, the change of the file name include the timestamp (which is a change from v15.9 --> v16.0) was a pretty serious breaking change that ended pretty much all of our builds today. We took some time to sort out that we could make it work with the wildcard syntax with another library, trx2junit; before that, we did not believe we could find a way forward without pegging the tag you referenced above.

I'm in no position to describe the timestamp as unexpected behavior; only it is definitely breaking behavior and we can adapt.

@richlander
Copy link
Member

We should document this @mthalman. Can you take a first crack at that?

@MichaelSimons
Copy link
Member

This breaking changes is discussed in the #1042 announcement. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants