-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit 331ae036bed29021d3326c79e2339a7efd95a4b6 breaks testing #1034
Comments
@DSANTIMORE - You can unblock yourself while we investigate this by referencing the previous version of the image in this way: |
Thank you for the quick reply. And we've found a way to use wild cards correctly to handle it more elegantly, as well. |
@DSANTIMORE - Can you provide details on the actual and expected behaviors you're seeing? From looking at microsoft/vstest#1876, it looks like the only work that has been done so far is to add a timestamp at the end of the user-provided log file name. You're saying that after making use of the latest changes from 331ae03, you're no longer seeing the timestamp automatically added at the end log file name? |
@mthalman , my apologies, I didn't write up a very good summary. The breaking behavior was the addition of the timestamp. I think your tag note above is a sufficient answer for me; basically, the change of the file name include the timestamp (which is a change from v15.9 --> v16.0) was a pretty serious breaking change that ended pretty much all of our builds today. We took some time to sort out that we could make it work with the wildcard syntax with another library, trx2junit; before that, we did not believe we could find a way forward without pegging the tag you referenced above. I'm in no position to describe the timestamp as unexpected behavior; only it is definitely breaking behavior and we can adapt. |
We should document this @mthalman. Can you take a first crack at that? |
This breaking changes is discussed in the #1042 announcement. Closing. |
331ae03 appears to break the test output file name conventions that used to exist (this is mentioned microsoft/vstest#1876 (comment) as well).
Is there a way to target the before this commit (so, dotnet test 15.9) using tagging of FROM microsoft/dotnet:2.1-sdk
Many thanks for the repy.
The text was updated successfully, but these errors were encountered: