Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Nullable Reference Type Annotation: AssociatedMetadataTypeTypeDescriptionProvider #25957

Closed
1 of 2 tasks
jeffhandley opened this issue Sep 3, 2021 · 0 comments · Fixed by #26212
Closed
1 of 2 tasks
Assignees
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 6 Issues and PRs for the .NET 6 release source incompatible Source code may encounter a breaking change in behavior when targeting the new version.

Comments

@jeffhandley
Copy link
Member

Description

There were a few APIs in System.ComponentModel.DataAnnotations.AssociatedMetadataTypeTypeDescriptionProvider that were previously unannotated for Nullable Reference Types. The annotations have now been applied.

These changes were made in dotnet/runtime#57932.

Version

.NET 6 RC2

Previous behavior

The APIs were treated as "oblivious" with regard to reference type nullability.

New behavior

The APIs are now annotated with their accurate nullability conditions.

Type of breaking change

  • Binary incompatible: Existing binaries may encounter a breaking change in behavior, such as failure to load/execute or different run-time behavior.
  • Source incompatible: Source code may encounter a breaking change in behavior when targeting the new runtime/component/SDK, such as compile errors or different run-time behavior.

Reason for change

These APIs had dependencies on other APIs that were previously unannotated. The dependencies have since been annotated, allowing these APIs to also be annotated, completing our nullable reference type annotations for the shared framework libraries.

Recommended action

Update code calling these APIs to reflect the revised nullability contracts.

Feature area

Core .NET libraries

Affected APIs

@jeffhandley jeffhandley added doc-idea breaking-change Indicates a .NET Core breaking change labels Sep 3, 2021
@dotnet-bot dotnet-bot added ⌚ Not Triaged Not triaged 🏁 Release: .NET 6 Issues and PRs for the .NET 6 release source incompatible Source code may encounter a breaking change in behavior when targeting the new version. labels Sep 3, 2021
@dotnet-bot dotnet-bot removed the ⌚ Not Triaged Not triaged label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 6 Issues and PRs for the .NET 6 release source incompatible Source code may encounter a breaking change in behavior when targeting the new version.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants