From a299b0c3a315b5c7d71f475c3d870df7fa6271ac Mon Sep 17 00:00:00 2001 From: Vance Morrison Date: Wed, 13 Sep 2017 16:19:44 -0700 Subject: [PATCH 1/3] Use Portable PDBs and turn on SourceLink This makes us uniform. Allows VSCode (which does not suport MSPdbs) use on Windows. --- dir.props | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dir.props b/dir.props index dc429afec992..b8ff35740c81 100644 --- a/dir.props +++ b/dir.props @@ -165,6 +165,12 @@ true + + + Portable + true + + From 54cfca559f6773326fcc0a646c163fbe53356674 Mon Sep 17 00:00:00 2001 From: Vance Morrison Date: Thu, 19 Oct 2017 16:38:32 -0700 Subject: [PATCH 2/3] Updated build tools needed to make sure CodeCoverage works Also update docs about code coverage. --- BuildToolsVersion.txt | 2 +- Documentation/building/code-coverage.md | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/BuildToolsVersion.txt b/BuildToolsVersion.txt index 8ab537c9f694..d6ea201305e3 100644 --- a/BuildToolsVersion.txt +++ b/BuildToolsVersion.txt @@ -1 +1 @@ -2.0.0-prerelease-02124-02 +2.0.0-prerelease-02126-01 diff --git a/Documentation/building/code-coverage.md b/Documentation/building/code-coverage.md index 73e5f6a61c6b..3f6e50edcfe6 100644 --- a/Documentation/building/code-coverage.md +++ b/Documentation/building/code-coverage.md @@ -78,4 +78,7 @@ Some of the libraries for which contracts and tests live in the corefx repo are 1. Follow the steps outlined at [Testing with Private CoreClr Bits](https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/developer-guide.md#testing-with-private-coreclr-bits). Make sure to include the optional steps listed as being required for code coverage. 2. Add /p:CodeCoverageAssemblies="System.Private.CoreLib" to the previously discussed msbuild command, e.g. msbuild /t:BuildAndTest /p:Coverage=true /p:CodeCoverageAssemblies="System.Private.CoreLib" +Note that you will also want to copy the System.Private.CoreLib.pdb along with the System.Private.CoreLib.dll. As of 10/2017 this PDB must be a windows PDB (Hopefully by early 2018 OpenCOver will directly support portable PDBs. +You can determine if it is a windows PDB by doing 'more System.Private.CoreLib.pdb. If it begins with 'Microsoft C/C++ MSF 7.00' it is a windows PDB) If you need a windows PDB the Pdb2Pdb tool will convert (or you can do a msbuild /t:rebuild /p:DebugType=full in the src\mscorlib) + The resulting code coverage report should now also include details for System.Private.CoreLib. From 4f6e3ef97f7bc426263a3f87ebfee92f4c7b02f8 Mon Sep 17 00:00:00 2001 From: Vance Morrison Date: Fri, 27 Oct 2017 08:37:43 -0700 Subject: [PATCH 3/3] Update to latest build tools --- BuildToolsVersion.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BuildToolsVersion.txt b/BuildToolsVersion.txt index d6ea201305e3..948c5f2e99eb 100644 --- a/BuildToolsVersion.txt +++ b/BuildToolsVersion.txt @@ -1 +1 @@ -2.0.0-prerelease-02126-01 +2.0.0-prerelease-02127-07