From 918d953767a8a9988c9e075254b70866e8b24e76 Mon Sep 17 00:00:00 2001
From: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Date: Fri, 24 Jul 2020 09:45:11 -0700
Subject: [PATCH] Use Microsoft.CodeAnalysis.PublicApiAnalyzers (#24188)
* Use Microsoft.CodeAnalysis.PublicApiAnalyzers
- #4259 1/2
- followup 2/3 for 5266918ed2be
- includes baselines for 16 MVC projects
- will automated further additions in another PR
- suppress warnings that may cause back-compat problems if fixed
nit: sort `@(LatestPackageReference)` a bit better
---
eng/Dependencies.props | 3 +-
eng/Versions.props | 1 +
eng/targets/CSharp.Common.targets | 24 +
.../src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 852 ++++++
.../Mvc.ApiExplorer/src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 98 +
src/Mvc/Mvc.Core/src/PublicAPI.Shipped.txt | 1 +
src/Mvc/Mvc.Core/src/PublicAPI.Unshipped.txt | 2453 +++++++++++++++++
.../ControllerLinkGeneratorExtensions.cs | 11 +-
.../Routing/PageLinkGeneratorExtensions.cs | 7 +-
src/Mvc/Mvc.Cors/src/PublicAPI.Shipped.txt | 1 +
src/Mvc/Mvc.Cors/src/PublicAPI.Unshipped.txt | 12 +
.../src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 38 +
.../src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 13 +
.../src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 137 +
.../src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 78 +
.../src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 54 +
.../src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 24 +
src/Mvc/Mvc.Razor/src/PublicAPI.Shipped.txt | 1 +
src/Mvc/Mvc.Razor/src/PublicAPI.Unshipped.txt | 264 ++
.../Mvc.RazorPages/src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 638 +++++
.../Mvc.TagHelpers/src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 373 +++
src/Mvc/Mvc.Testing/src/PublicAPI.Shipped.txt | 1 +
.../Mvc.Testing/src/PublicAPI.Unshipped.txt | 48 +
.../src/PublicAPI.Shipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 1160 ++++++++
src/Mvc/Mvc/src/PublicAPI.Shipped.txt | 1 +
src/Mvc/Mvc/src/PublicAPI.Unshipped.txt | 10 +
37 files changed, 6309 insertions(+), 5 deletions(-)
create mode 100644 src/Mvc/Mvc.Abstractions/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.Abstractions/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.ApiExplorer/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.ApiExplorer/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.Core/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.Core/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.Cors/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.Cors/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.DataAnnotations/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.DataAnnotations/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.Formatters.Json/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.Formatters.Json/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.Formatters.Xml/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.Formatters.Xml/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.Localization/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.Localization/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.NewtonsoftJson/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.NewtonsoftJson/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.Razor.RuntimeCompilation/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.Razor.RuntimeCompilation/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.Razor/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.Razor/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.RazorPages/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.RazorPages/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.TagHelpers/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.TagHelpers/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.Testing/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.Testing/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc.ViewFeatures/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc.ViewFeatures/src/PublicAPI.Unshipped.txt
create mode 100644 src/Mvc/Mvc/src/PublicAPI.Shipped.txt
create mode 100644 src/Mvc/Mvc/src/PublicAPI.Unshipped.txt
diff --git a/eng/Dependencies.props b/eng/Dependencies.props
index 0e3a756de797..081db9be887f 100644
--- a/eng/Dependencies.props
+++ b/eng/Dependencies.props
@@ -106,6 +106,7 @@ and are generated based on the last package release.
+
@@ -161,6 +162,7 @@ and are generated based on the last package release.
+
@@ -178,7 +180,6 @@ and are generated based on the last package release.
-
diff --git a/eng/Versions.props b/eng/Versions.props
index 00896bd2bc3b..d11516a86194 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -219,6 +219,7 @@
3.7.0-4.20351.7
3.7.0-4.20351.7
3.7.0-4.20351.7
+ 3.3.0-beta2.final
3.0.0
1.0.0-20200708.1
3.19.8
diff --git a/eng/targets/CSharp.Common.targets b/eng/targets/CSharp.Common.targets
index 65d5f3b0fcb1..62b746203550 100644
--- a/eng/targets/CSharp.Common.targets
+++ b/eng/targets/CSharp.Common.targets
@@ -6,6 +6,30 @@
.NETFramework
+
+
+ <_TFMDirectory>$(TargetFramework)
+ <_TFMDirectory Condition=" '$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)' ">netcoreapp
+
+
+ $(NoWarn);RS0041
+
+
+
+
+
+
+
+
+
+
+
diff --git a/src/Mvc/Mvc.Abstractions/src/PublicAPI.Shipped.txt b/src/Mvc/Mvc.Abstractions/src/PublicAPI.Shipped.txt
new file mode 100644
index 000000000000..7dc5c58110bf
--- /dev/null
+++ b/src/Mvc/Mvc.Abstractions/src/PublicAPI.Shipped.txt
@@ -0,0 +1 @@
+#nullable enable
diff --git a/src/Mvc/Mvc.Abstractions/src/PublicAPI.Unshipped.txt b/src/Mvc/Mvc.Abstractions/src/PublicAPI.Unshipped.txt
new file mode 100644
index 000000000000..af5b4f50c8b8
--- /dev/null
+++ b/src/Mvc/Mvc.Abstractions/src/PublicAPI.Unshipped.txt
@@ -0,0 +1,852 @@
+#nullable enable
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.ActionConstraints.get -> System.Collections.Generic.IList?
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.ActionConstraints.set -> void
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.ActionDescriptor() -> void
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.AttributeRouteInfo.get -> Microsoft.AspNetCore.Mvc.Routing.AttributeRouteInfo?
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.AttributeRouteInfo.set -> void
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.BoundProperties.get -> System.Collections.Generic.IList!
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.BoundProperties.set -> void
+Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor.EndpointMetadata.get -> System.Collections.Generic.IList