Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test OTEL retries works #3086

Closed
JamesNK opened this issue Mar 21, 2024 · 7 comments · Fixed by #3351
Closed

Test OTEL retries works #3086

JamesNK opened this issue Mar 21, 2024 · 7 comments · Fixed by #3351
Assignees

Comments

@JamesNK
Copy link
Member

JamesNK commented Mar 21, 2024

Test https://www.nuget.org/packages/OpenTelemetry.Exporter.OpenTelemetryProtocol/1.8.0-beta.1 retry logic works.

Can test by delaying startup of dashboard and then ensuring that telemetry from apps is eventually correctly recorded.

@DamianEdwards
Copy link
Member

@vishweshbankwar
Copy link

@JamesNK - Just the heads up. A change is coming for this open-telemetry/opentelemetry-dotnet#5495

It should be released tomorrow. I will update here, once the package is available with the change.

@vishweshbankwar
Copy link

@JamesNK
Copy link
Member Author

JamesNK commented Apr 3, 2024

To test out retries I updated OTEL to 1.8.0, added the env var, and a 20 second delay to starting up the server.

I don't see startup logging from .NET projects in the server:

image

What I expected to see:

image

Retries don't appear to be working. How many times does it retry? How long does it try to retry?

@JamesNK
Copy link
Member Author

JamesNK commented Apr 3, 2024

PR to update to 1.8.0 - #3351

@vishweshbankwar
Copy link

vishweshbankwar commented Apr 3, 2024

@JamesNK - Could you try increasing the timeout period? https://github.com/open-telemetry/opentelemetry-dotnet/blob/9b246750ab76e94986fc433d5c7af046a137e477/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs#L113-L117?

How long does it try to retry? - The retries will continue until the total time does not exceed the configured timeout for each export.

How many times does it retry - There is no defined # of retires, it is only controlled by the timeout period (which is max time the exporter can spend on exporting each batch).

@JamesNK
Copy link
Member Author

JamesNK commented Apr 3, 2024

Thanks. I tested with a 10 second startup delay and it works with the retry env var and doesn't work without the retry env var. That means it's working as expected.

10 second timeout is fine as a default.

@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants