Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FullAssemblySIgningSupported should not default to false in non-source only modes. #15301

Closed
mmitche opened this issue Dec 4, 2024 · 1 comment
Closed

FullAssemblySIgningSupported should not default to false in non-source only modes. #15301

mmitche opened this issue Dec 4, 2024 · 1 comment

Comments

@mmitche
Copy link
Member

mmitche commented Dec 4, 2024 •
edited
Loading

In #12940, RedHat added a property that disables full assembly signing by default. This causes public sign to be used. This is not desirable when building as MSFT, as we need to strong name sign.

This setting should not default to false except in source-only modes. In addition, this setting should ideally not be set up in the source build targets. It should be in StrongName.targets or another appropriate place.
@mmitche mmitche converted this from a draft issue Dec 4, 2024
This was referenced Dec 4, 2024
Merged
Merged
@mmitche
Copy link
Member Author

mmitche commented Dec 9, 2024

Closed with #15303

@mmitche mmitche closed this as completed Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in .NET Unified Build Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
.NET Unified Build
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmitche