Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counts to output? #63

Closed
billyvg opened this issue Jan 28, 2021 · 2 comments · Fixed by #65
Closed

Add counts to output? #63

billyvg opened this issue Jan 28, 2021 · 2 comments · Fixed by #65
Assignees
Labels
enhancement New feature or request

Comments

@billyvg
Copy link
Contributor

billyvg commented Jan 28, 2021

So one of the ways we're using this is to find added/modified files to pass to our linter. We use list-files: shell since we pass this list of files to the linter. However, we'd also like to get the count of files so that we can do some different conditionals based on the # of changed files.

Any objections to adding the count to the action outputs?

@dorny
Copy link
Owner

dorny commented Jan 29, 2021

If there is use-case for it then why not. I will add it later today.
We already have ${FILTER_NAME}_files so this could be ${FILTER_NAME}_count or something like that.

@dorny dorny self-assigned this Jan 29, 2021
@dorny dorny added the enhancement New feature or request label Jan 29, 2021
@dorny dorny mentioned this issue Jan 29, 2021
@dorny dorny closed this as completed in #65 Jan 29, 2021
@billyvg
Copy link
Contributor Author

billyvg commented Jan 29, 2021

Thank you once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants