Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to re-build esprima-bin-wrapper #57

Open
tinchodias opened this issue Mar 30, 2021 · 0 comments · May be fixed by #58
Open

Explain how to re-build esprima-bin-wrapper #57

tinchodias opened this issue Mar 30, 2021 · 0 comments · May be fixed by #58

Comments

@tinchodias
Copy link
Collaborator

Pharo code invokes a node js file that's the webpack output.

Invoked js file: esprima-bin-wrapper/dist/esprima-bin-wrapper.node.js
Invocation: src/Hunter-AST.package/HNEsprimaWrapper.class/class/esprimaWrapperPathRelativeTo..st

I propose to explain this in root's README or in the one of this subdirectory: https://github.com/dorellang/hunter/blob/master/esprima-bin-wrapper/README.md


Motivation: there are pending updates to dependencies (for example, 5 PR generated by "dependabot"). I didn't update yet because, in part, they don't seem to be really a problem, but also because I didn't know how to re-build the js that's invoked by the code. Today I realized it was not difficult at all, but I think it's better to explain it in README.

@tinchodias tinchodias linked a pull request Mar 30, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant