Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KHR_draco_mesh_compression support. #70

Closed
donmccurdy opened this issue Feb 13, 2018 · 9 comments
Closed

Add KHR_draco_mesh_compression support. #70

donmccurdy opened this issue Feb 13, 2018 · 9 comments

Comments

@donmccurdy
Copy link
Owner

donmccurdy commented Feb 13, 2018

See mrdoob/three.js#13194

@zellski
Copy link
Contributor

zellski commented Feb 13, 2018

Oh I’ve been waiting for this. Do you intend to update your “public web tool” with the relevant code?

@donmccurdy
Copy link
Owner Author

Yep, this issue is just meant to track adding it to the web tool. The three.js PR is not going to land until after the r90 release, but we could probably merge the changes here before that.

@donmccurdy
Copy link
Owner Author

donmccurdy commented Feb 14, 2018

Staged an experimental version:

Currently it only works for the first Draco model imported per pageview, and throws an error for the next. Not sure yet whether that's a bug in my implementation or the decoder module. Fixed.

@zellski
Copy link
Contributor

zellski commented Feb 14, 2018

It's so great to be able to FBX2glTF --draco --binary again, and just pull the (much-shrunken) result right into this viewer.

@cx20
Copy link

cx20 commented Feb 18, 2018

I tried glTF-Draco format file using experimental demo site.
https://gltf-viewer-experimental.donmccurdy.com/

When loading failed, the following error was output to the console.

bundle.js?v=r90:223 
  THREE.DRACOLoader: Decoding failed: Failed to decode geometry data.
  convertDracoGeometryTo3JS @ bundle.js?v=r90:223

The arguments used for the conversion are as follows.

COLLADA2GLTF-bin.exe -i Duck.dae -o Duck.gltf -v 2.0 -d -s

I could not judge whether it is a converter issue or a viewer problem.

@donmccurdy
Copy link
Owner Author

Thanks @cx20 — the COLLADA2GLTF file looks ok in Babylon and gltf.insimo.com (slightly different implementation in three.js) so i believe this a bug in my viewer or THREE.GLTFLoader. Will look into that soon.

@donmccurdy
Copy link
Owner Author

Released draco support. The COLLADA2GLTF issue isn't limited to my viewer, it happens in plain three.js as well, so I've opened mrdoob/three.js#13870.

@EtagiBI
Copy link

EtagiBI commented Nov 15, 2018

Hmm... Is it a validator problem then?
image

@lexaknyazev
Copy link

Yes. It means that the validator doesn't support that extension. The message will be refined in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants