From f60b2ed08e1b297f94ca4ec3073c5c71a7e6d5ee Mon Sep 17 00:00:00 2001 From: Dominic Go <18517029+dominicstop@users.noreply.github.com> Date: Sat, 22 Apr 2023 01:53:54 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20Docs:=20Update=20TODO?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- docs/TODO.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/TODO.md b/docs/TODO.md index bccf17d4..e8ae62c8 100644 --- a/docs/TODO.md +++ b/docs/TODO.md @@ -73,11 +73,11 @@ - [x] **Subtask** - `TODO:2023-04-21-23-25-35` - Impl. prop `sheetPrefersEdgeAttachedInCompactHeight`. - [x] **Subtask** - `TODO:2023-04-21-23-25-47` - Impl. prop `sheetWidthFollowsPreferredContentSizeWhenEdgeAttached`. - [x] **Subtask** - `TODO:2023-04-21-23-26-03` - Impl. prop `sheetPrefersGrabberVisible`. - - [ ] **Subtask** - `TODO:2023-04-21-23-24-47` - Impl. prop `sheetSmallestUndimmedDetentIdentifier`. + - [ ] **Subtask** - `TODO:2023-04-21-23-24-47` - Impl. prop `sheetLargestUndimmedDetentIdentifier`. - [ ] **Subtask** - `TODO:2023-04-21-23-26-13` - Impl. prop `sheetPreferredCornerRadius`. - [ ] **Subtask** - `TODO:2023-04-21-23-24-03` - Impl. prop `sheetSelectedDetentIdentifier`. - - [ ] **Subtask** - `TODO:2023-04-21-23-24-39` - Impl. prop `sheetShouldAnimateSelectedDetentIdentifierChanges`. + - [ ] **Subtask** - `TODO:2023-04-21-23-24-39` - Impl. prop `sheetShouldAnimateChanges`. - [ ] **Subtask**: `TODO:2023-04-21-23-26-13` - Impl. modal event `onModalDetentDidCompute`. - [ ] **Subtask** - `TODO:2023-04-21-00-31-46` - Impl. modal content prop `modalPreferredContentSize`. * For example, `UIModalPresentationStyle.pageSheet` uses an explicit size that the system provides. @@ -127,6 +127,7 @@ - [ ] `TODO:2023-04-21-23-42-42` - Deprecate `presentViaMount` - [ ] `TODO:` - Deprecate `ModalView.setVisibility` + `childProps`, and replace with `ModalContext.modalContentProps`. - [ ] `TODO:` - Update `ModalView.setVisibility` - Add options params + `shouldTemporarilyDisableSwipeGestureWhileTransitioning`. +- [ ] `TODO:` - Update `ModalView.getProps` - Match default values from `RNIModalView` native props. - [ ] `TODO:2023-04-21-23-42-49` - Add prop to disable user-interaction from modal * Can be achieved via `UIView.userInteractionEnabled`, or via `RCTTouchHander.isEnabled`.