From e2a842e491348669bc203b6a2a4b067b07ea8bc2 Mon Sep 17 00:00:00 2001
From: Dominic Go <18517029+dominicstop@users.noreply.github.com>
Date: Mon, 27 Mar 2023 21:24:12 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20Docs:=20Update=20TODO?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
docs/TODO.md | 31 +++++++++++++++----------------
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/docs/TODO.md b/docs/TODO.md
index 5a920163..1ee5eb33 100644
--- a/docs/TODO.md
+++ b/docs/TODO.md
@@ -10,7 +10,13 @@
- [ ] **Subtask** - `TODO:2023-03-24-01-14-26` - Remove/Replace `UIWindow.key`.
- [ ] **Subtask** - `TODO:2023-03-20-21-29-36` - Move `RNIModalManager` helper functions to `RNIUtilities`.
- [ ] **Subtask** - `TODO:2023-03-04-13-22-34` - **Refactor**: Remove `ViewModuleRelatedTypes`
- * **Desc**: Move/Consolidate `src/types/ViewModuleRelatedTypes` to `react-native-utilities` and remove.
+ * **Desc**: Move/Consolidate `src/types/ViewModuleRelatedTypes` to `react-native-utilities` and remove.
+
+
+
+ - [ ] **Subtask** - `TODO:2023-03-22-12-18-37` - **Refactor**: Remove `deinitControllers`
+
+ * Refactor `RNIModalView` so that we don't have to constantly cleanup.
@@ -54,7 +60,9 @@
- [ ] `TODO:2023-03-04-13-15-11` - **Refactor**: Use Will/Did Prefix for `RNIModalView` Events
+
* **Desc**: Refactor `RNIModalView` events to use "will/did" prefix, and deprecate old event names (for backwards compatibility).
+
* Remove `RNIModalView.onModalDismiss`
* Remove `RNIModalView.onModalShow`
* Rename `RNIModalView.onModalAttemptDismiss` to `RNIModalView.onModalDidAttemptToDismiss`
@@ -77,6 +85,10 @@
* Add invocation for deprecated event `ModalView.onModalFocus`
* Update examples.
+
+
+ * [ ] **Subtask** - `TODO:2023-03-04-13-06-27` - **Impl**: Update `RNIModalView` Native Events
+
- [ ] `TODO:2023-03-04-06-34-28` - Library Native Cleanup
@@ -105,11 +117,6 @@
- * [ ] **Subtask** - `TODO:2023-03-22-12-18-37` - **Refactor**: Remove `deinitControllers`
- * Refactor `RNIModalView` so that we don't have to constantly cleanup.
-
-
-
* [x] **Subtask** - `TODO:2023-03-22-12-09-34` - Move to `get` property called `synthesizedNativeEventBase`
* **Desc**: Refactor `createModalNativeEventDict`.
@@ -128,7 +135,7 @@
- * [ ] **Subtask** - `TODO:2023-03-04-15-39-46` - **Impl**: `RNIModalManager`
+ * [x] **Subtask** - `TODO:2023-03-04-15-39-46` - **Impl**: `RNIModalManager`
* **Desc**: Implement `RNIModalManager` singleton for handling modal focus/blur logic.
* Modal focus/blur re-write.
* Consolidate focus/blur related logic to this class, This class will be notified whenever a new modal is presented or dismissed.
@@ -154,10 +161,7 @@
- - [ ] **Subtask** - `TODO:2023-03-05-00-33-15` - **Refactor**: Re-write `dismissModalByID`
- * **Desc**: Cleanup + Re-write `RNIModalViewModule.dismissModalByID`.
-
-
+ - [ ] **Subtask** - `TODO:2023-03-05-00-33-15` - **Refactor**: Remove `RNIModalViewModule.dismissModalByID`.
- [x] **Subtask** - `TODO:2023-03-04-15-38-02` - **Refactor**: Remove `RNIModalViewManager.currentModalLevel`.
@@ -167,11 +171,6 @@
- - [ ] **Subtask** - `TODO:2023-03-04-13-06-27` - **Impl**: Update `RNIModalView` Native Events
- * **Desc**: Update `RNIModalView` native event parameters (i.e. send over more relevant data).
-
-
-
- Related:
* `TODO:2023-03-04-05-25-44` - Library Cleanup
* `Note:2023-03-04-02-58-31`