From e0734117c598f1aaed058f02137df0336a8aa4a9 Mon Sep 17 00:00:00 2001 From: Dominic Go <18517029+dominicstop@users.noreply.github.com> Date: Mon, 27 Mar 2023 16:41:51 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20Docs:=20Update=20TODO?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- docs/TODO.md | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/docs/TODO.md b/docs/TODO.md index 008a6e1f..5a920163 100644 --- a/docs/TODO.md +++ b/docs/TODO.md @@ -53,6 +53,32 @@
+- [ ] `TODO:2023-03-04-13-15-11` - **Refactor**: Use Will/Did Prefix for `RNIModalView` Events + * **Desc**: Refactor `RNIModalView` events to use "will/did" prefix, and deprecate old event names (for backwards compatibility). + * Remove `RNIModalView.onModalDismiss` + * Remove `RNIModalView.onModalShow` + * Rename `RNIModalView.onModalAttemptDismiss` to `RNIModalView.onModalDidAttemptToDismiss` + * Add invocation for deprecated event `ModalView.onModalAttemptDismiss`. + * Remove `RNIModalView.onModalBlur` + * Remove `RNIModalView.onModalFocus` + * Move deprecated native modal events from `RNIModalViewEvents` to `RNIModalViewDeprecatedEvents`. + * Update typescript types for modal event objects to match native event object. + * Impl. `RNIModalView.onModalWilllDismiss` + * Impl. `RNIModalView.onModalDidlDismiss` + * Add invocation for deprecated event `ModalView.onModalDismiss` + * Impl. `RNIModalView.onModalWillShow` + * Impl. `RNIModalView.onModalDidShow` + * Add invocation for deprecated event `ModalView.onModalShow` + * Impl. `RNIModalView,onModalWillBlur` + * Impl. `RNIModalView.onModalDidBlur` + * Add invocation for deprecated event `ModalView.onModalBlur` + * Impl. `RNIModalView.onModalWillFocus` + * Impl. `RNIModalView.onModaDidFocus` + * Add invocation for deprecated event `ModalView.onModalFocus` + * Update examples. + +
+ - [ ] `TODO:2023-03-04-06-34-28` - Library Native Cleanup * **Desc**: Rewrite native to be more readable/consistent. @@ -146,9 +172,6 @@
- * [ ] **Subtask** - `TODO:2023-03-04-13-15-11` - **Refactor**: Use Will/Did Prefix for `RNIModalView` Events - * **Desc**: Rename `RNIModalView` events to use "will/did" prefix, and deprecate old event names (for backwards compatibility). - - Related: * `TODO:2023-03-04-05-25-44` - Library Cleanup * `Note:2023-03-04-02-58-31`