From 55e72b41defc6fc7117650b85b07f7e7cc57f037 Mon Sep 17 00:00:00 2001
From: Dominic Go <18517029+dominicstop@users.noreply.github.com>
Date: Tue, 10 Jan 2023 06:14:42 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A0=20Refactor:=20Rename=20`ModalView.?=
 =?UTF-8?q?state.visible`?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Summary: Rename `ModalView.state.visible` to `shouldMountModalContent`.
---
 src/components/ModalView/ModalView.tsx     | 10 +++++-----
 src/components/ModalView/ModalViewTypes.ts |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/components/ModalView/ModalView.tsx b/src/components/ModalView/ModalView.tsx
index 01ab2bf0..cc8c637e 100644
--- a/src/components/ModalView/ModalView.tsx
+++ b/src/components/ModalView/ModalView.tsx
@@ -60,7 +60,7 @@ export class ModalView extends
     this.emitter = new TSEventEmitter();
 
     this.state = {
-      visible: false,
+      shouldMountModalContent: false,
       childProps: null,
       enableSwipeGesture: props.enableSwipeGesture,
       isModalInPresentation: props.isModalInPresentation,
@@ -69,7 +69,7 @@ export class ModalView extends
 
   componentWillUnmount() {
     const { autoCloseOnUnmount } = this.getProps();
-    const { visible } = this.state;
+    const { shouldMountModalContent: visible } = this.state;
 
     if (autoCloseOnUnmount && visible) {
       this.setVisibility(false);
@@ -170,7 +170,7 @@ export class ModalView extends
   };
 
   setVisibility = async (nextVisible, childProps = null) => {
-    const { visible: prevVisible } = this.state;
+    const { shouldMountModalContent: prevVisible } = this.state;
 
     const didChange = (prevVisible !== nextVisible);
 
@@ -299,7 +299,7 @@ export class ModalView extends
     );
 
     this.setState({
-      visible: false,
+      shouldMountModalContent: false,
       childProps: null,
       // reset state values from props
       enableSwipeGesture: props.enableSwipeGesture,
@@ -366,7 +366,7 @@ export class ModalView extends
         {...overrideProps}
         {...props.viewProps}
       >
-        {state.visible && (
+        {state.shouldMountModalContent && (
           <View
             style={[styles.modalContentContainer, props.containerStyle]}
             collapsable={false}
diff --git a/src/components/ModalView/ModalViewTypes.ts b/src/components/ModalView/ModalViewTypes.ts
index 335e17d3..6e43b797 100644
--- a/src/components/ModalView/ModalViewTypes.ts
+++ b/src/components/ModalView/ModalViewTypes.ts
@@ -43,7 +43,7 @@ export type ModalViewProps =
   ViewProps & ModalViewBaseProps;
 
 export type ModalViewState = {
-  visible: boolean;
+  shouldMountModalContent: boolean;
   childProps: unknown;
   enableSwipeGesture: boolean;
   isModalInPresentation: boolean;