Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop fail when using unregistered model #1794

Closed
notV4l opened this issue Apr 8, 2024 · 2 comments · Fixed by #2093
Closed

Loop fail when using unregistered model #1794

notV4l opened this issue Apr 8, 2024 · 2 comments · Fixed by #2093
Labels
bug Something isn't working torii
Milestone

Comments

@notV4l
Copy link
Collaborator

notV4l commented Apr 8, 2024

Describe the bug
emit and event (i think StoreSetRecord) using unregistered model leads to fail loop in torii with following error
ERROR tori_core::engine: Getting block. error=no rows returned by a query that expected to return at least one row

Expected behavior
Ignore/warning for unregistered models

Additional context
0.6.0

@notV4l notV4l added bug Something isn't working torii labels Apr 8, 2024
@glihm glihm added this to the 1.0.0 milestone Jun 19, 2024
@glihm glihm changed the title [torii] loop fail when using unregistered model Loop fail when using unregistered model Jun 19, 2024
@glihm
Copy link
Collaborator

glihm commented Jun 19, 2024

Should be checked on 0.7.1.

@glihm
Copy link
Collaborator

glihm commented Jun 20, 2024

@notV4l for context, in which scenario this event is emitted without having the model registered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working torii
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants