Allow PHP 8 #1102
Merged
Allow PHP 8 #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Dec 23, 2020
This was referenced Dec 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes and replaces #980
Because so many deps forbid PHP8 unless you bump them also, this PR also bumps them.
Since bumping phpstan also adds new rules that the codebase is not compliant with, I generated a baseline to still be green on the static analysis job. This should be fixed in a later PR.
Roave BC Checkalso reports false positives BC breaks related to eg symfony/console bumping from v4 to v5. I commented the job: fixing this is also for another PR.This is a canonical example of why dependencies should have broad version constraints: this would have reduced the size of the PR, thus would have reduced the risk. Instead, narrow constraints force doing extra unrelated work that puts the stability at risk. Let's decorrelate these other tasks in separate PRs, as just advised.