Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHPStorm stubs from dependencies #4468

Closed
DaanBiesterbos opened this issue Dec 14, 2020 · 2 comments
Closed

Remove PHPStorm stubs from dependencies #4468

DaanBiesterbos opened this issue Dec 14, 2020 · 2 comments

Comments

@DaanBiesterbos
Copy link

Feature Request

Please consider removing the (dev) dependency jetbrains/phpstorm-stubs.

IntelliejIDEA and PHPStorm are producing a lot of duplicate class warnings. I don't see any functional benefits of having (outdated!) stubs in my vendor folder. I would say that this is the responsibility of my IDE. I can switch back and forth PHP version and get accurate information in any project, all the time.
Sure, I can mark the directories as excluded to get rid of the warnings but still....

I don't understand why this dependency is here. Assuming most devs use a decent IDE there is no point in installing stubs right? And even if we'd all be using notepad++ it still would not be Doctrine's responsbility. The current version is v2020.2. . What if another bundle decides to require the stubs from ^2020? There would be a version conflict. And for what? For interfaces of standard PHP classes I neither use or need.

  1. The stubs are in conflict with IDE
  2. Stubs are subject to change, other tools are more suitable to provide this functionality.
  3. There may be version conflicts for some people (the dependency is already outdated)
  4. No functional benefits

I would purpose to suggest this package instead. I don't think it is a bad thing to expect developers to take care of this themselves. If someone needs stubs they can easily install the dependency themselves I would say.

@morozov
Copy link
Member

morozov commented Feb 13, 2021

IntelliejIDEA and PHPStorm are producing a lot of duplicate class warnings.

What is the setup? Do you develop the DBAL or you use it as a dependency? In the latter case, Composer shouldn't install any stubs since they are a development dependency.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants