From b0ed680fc3dd7be4f98c3956e2c382615841b652 Mon Sep 17 00:00:00 2001 From: Sergei Morozov Date: Fri, 22 Feb 2019 16:23:50 -0800 Subject: [PATCH] Marked some test classes abstract 1. SchemaManagerFunctionalTestCase can be run only via an extending class. Otherwise, it skips all tests. If the test case is represented as an abstract class, PhpStorm will offer a choise of concrete classes which is very handy when debugging test failures. 2. DbalFunctionalTestCase and DbalPerformanceTestCase are meant to be used as base classes and don't contain any tests. --- .../DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php | 2 +- tests/Doctrine/Tests/DbalFunctionalTestCase.php | 2 +- tests/Doctrine/Tests/DbalPerformanceTestCase.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php b/tests/Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php index 6c2679baebb..c9826f14243 100644 --- a/tests/Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php +++ b/tests/Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php @@ -46,7 +46,7 @@ use function strtolower; use function substr; -class SchemaManagerFunctionalTestCase extends DbalFunctionalTestCase +abstract class SchemaManagerFunctionalTestCase extends DbalFunctionalTestCase { /** @var AbstractSchemaManager */ protected $schemaManager; diff --git a/tests/Doctrine/Tests/DbalFunctionalTestCase.php b/tests/Doctrine/Tests/DbalFunctionalTestCase.php index 149db8bf998..1e37c3060e8 100644 --- a/tests/Doctrine/Tests/DbalFunctionalTestCase.php +++ b/tests/Doctrine/Tests/DbalFunctionalTestCase.php @@ -18,7 +18,7 @@ use function strpos; use function var_export; -class DbalFunctionalTestCase extends DbalTestCase +abstract class DbalFunctionalTestCase extends DbalTestCase { /** * Shared connection when a TestCase is run alone (outside of it's functional suite) diff --git a/tests/Doctrine/Tests/DbalPerformanceTestCase.php b/tests/Doctrine/Tests/DbalPerformanceTestCase.php index 0001431454a..f9bb40df38c 100644 --- a/tests/Doctrine/Tests/DbalPerformanceTestCase.php +++ b/tests/Doctrine/Tests/DbalPerformanceTestCase.php @@ -11,7 +11,7 @@ * and stopTiming at the end of all tests. Tests that do not start or stop * timing will fail. */ -class DbalPerformanceTestCase extends DbalFunctionalTestCase +abstract class DbalPerformanceTestCase extends DbalFunctionalTestCase { /** * time the test started