Add schema provider setting #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b0d468 to
2e06abb
Compare
2e06abb to
7f2621b
Compare
SenseException
requested changes
May 3, 2019
| } | ||
|
|
||
| $diffCommand = $container->findDefinition('doctrine_migrations.diff_command'); | ||
| $diffCommand->setArgument(0, new Reference($config['schema_provider'])); |
There was a problem hiding this comment.
A check if a valid $config['schema_provider'] value exists should happen.
Probably with a compiler pass?
|
This is possible in 3.x by using the services section in the new configuration format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #190 there's no setting for the diff command's schema provider. This adds a
schema_providersetting.Refs libero/content-store#8 (comment).