From e22b58954324b3593737438032412f15ed9602e9 Mon Sep 17 00:00:00 2001 From: "Daniel, Dao Quang Minh" Date: Fri, 27 Feb 2015 03:50:20 -0500 Subject: [PATCH] genericError constructors can accept nil error if the error is nil, we do not populate generic error's message, but the constructor will still return a valid error Signed-off-by: Daniel, Dao Quang Minh --- generic_error.go | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/generic_error.go b/generic_error.go index 05ab0a9d3..ff4d7248d 100644 --- a/generic_error.go +++ b/generic_error.go @@ -25,26 +25,32 @@ func newGenericError(err error, c ErrorCode) Error { if le, ok := err.(Error); ok { return le } - return &genericError{ + gerr := &genericError{ Timestamp: time.Now(), Err: err, - Message: err.Error(), ECode: c, Stack: stacktrace.Capture(1), } + if err != nil { + gerr.Message = err.Error() + } + return gerr } func newSystemError(err error) Error { if le, ok := err.(Error); ok { return le } - return &genericError{ + gerr := &genericError{ Timestamp: time.Now(), Err: err, ECode: SystemError, - Message: err.Error(), Stack: stacktrace.Capture(1), } + if err != nil { + gerr.Message = err.Error() + } + return gerr } type genericError struct {