Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

Dnn 9.4.1 fails to build #1168

Closed
1 task done
valadas opened this issue Sep 24, 2019 · 1 comment
Closed
1 task done

Dnn 9.4.1 fails to build #1168

valadas opened this issue Sep 24, 2019 · 1 comment
Labels
chore
Milestone
9.4.1

Comments

@valadas
Copy link
Contributor

valadas commented Sep 24, 2019

Description of bug

Building Dnn as described in the readme fails with:

Controllers\TabsController.cs(78,35): error CS1501: No overload for method 'GetPortalTabs' takes 10 arguments [D:\dnn-build\Temp\Dnn.AdminExperience-release-3.0.x\Library\Dnn.PersonaBar.Library\Dnn.PersonaBar.Library.csproj]
  • 9.4.1

I believe this is caused by the fact that the release/3.0.x branch here still references the RC1 nuget packages and not the official release because there is actually a 10 parameter overload as far as I can see...
@valadas valadas mentioned this issue Sep 24, 2019
Merged
@valadas valadas added the chore label Sep 24, 2019
@valadas valadas added this to the 9.4.1 milestone Sep 24, 2019
@valadas
Copy link
Contributor Author

valadas commented Sep 24, 2019

Merged and the theory was right, it fixed the build

@valadas valadas closed this as completed Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
9.4.1
Development

No branches or pull requests
1 participant
@valadas