Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

Improve Restart Application and Clear Cache experience #1084

Closed
6 tasks done
Timo-Breumelhof opened this issue Aug 5, 2019 · 11 comments
Closed
6 tasks done

Improve Restart Application and Clear Cache experience #1084

Timo-Breumelhof opened this issue Aug 5, 2019 · 11 comments
Labels

Comments

@Timo-Breumelhof
Copy link

Description of problem

Restarting DNN and clearing the cache takes too much time in DNN9 IMO.
I have been doing some templating on a module with heavy caching where I had to restart DNN for every change. That gets really annoying as you need to open the persona bar, click restart, DNN restarts, the persona bar opens again and you have to close the PB.|
Seems like nothing but after 10 times..

Description of solution

IMO we should add those two links to a more accessible location. I would say here:

image

Affected version

  • 9.3.2
  • 9.3.1
  • 9.2.2
  • 9.2.1
  • 9.2
  • 9.1.1
@valadas
Copy link
Contributor

valadas commented Aug 8, 2019

In my opinion those 2 options should be rarely used and as a last resort troubleshooting step, not something that needs prominent visibility. Also on large sites, accidentally clicking this can be trouble. There was also talks about improving the Clear Cache button to be a dropdown or a checkbox list for what to clear and it would need to be in one of the module I believe so we have enough space for that improved UI.

@Timo-Breumelhof
Copy link
Author

The thing is that with module with heavy caching you need to use those a lot if you are developing a template (example AF). They have been directly accessible in DNN 7 & 8 and AFAIK that hasn't been a real issue in the past and they would only be visible for Host users? (I think one could safely assume a host user will not restart dnn for fun)

@valadas valadas added the rfc label Aug 9, 2019
@valadas
Copy link
Contributor

valadas commented Aug 9, 2019

Modules have their own "Refresh" link in the module actions that should clear the module cache and staying in edit mode is also possible, so I think this covers that use case correctly, cache on the module level can also be disabled in the module settings. And the whole Dnn cache can be disabled in a development site too. I think we have enough ways to solve this without making these controls too easy to accidentally hit, IMO...

@bdukes
Copy link
Contributor

bdukes commented Aug 9, 2019

I agree with @valadas, those don't need to be easier to access than they already are (via the Servers or Prompt Persona Bar extensions).

@Timo-Breumelhof
Copy link
Author

Hmm, OK so I guess I'm alone in this. I use it a lot especially locally (after running sql scripts) and the reloading of the PB and not refreshing the page annoys me. Maybe we could at least close the PB and refresh the page after you reset DNN? Does that make sense to you? @valadas @bdukes

@bdukes
Copy link
Contributor

bdukes commented Aug 12, 2019

Yes, I would be okay with refreshing the main page after clicking Clear Cache 👍

@sleupold
Copy link

"clear cache" makes sense after working in the database - IMO the best additional place would be the SQL extension (next to run)

@Timo-Breumelhof Timo-Breumelhof changed the title Move Restart Application and Clear Cache to more accessible location Improve Restart Application and Clear Cache experience Aug 14, 2019
@Timo-Breumelhof
Copy link
Author

@bdukes @valadas not sure how you normally approach this, do I change this issue or do I close it and I create another one?

@bdukes
Copy link
Contributor

bdukes commented Aug 14, 2019

I think it's probably easier to create a new issue (which mentions this one for context), so the conversation can be more focused. 👍

@valadas
Copy link
Contributor

valadas commented Aug 15, 2019

@Timo-Breumelhof yes, this does make sense to me, the main concern here is to not make it too easy to hit accidentally, it has huge consequences on some multi-tenant sites or huge sites.

@valadas
Copy link
Contributor

valadas commented Sep 10, 2019

As per discussion, I am closing this issue if favour of more focused ones

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants