Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github release out of date #137

Closed
Moelf opened this issue Dec 5, 2022 · 7 comments
Closed

Github release out of date #137

Moelf opened this issue Dec 5, 2022 · 7 comments

Comments

@Moelf
Copy link
Contributor

Moelf commented Dec 5, 2022

and documentation is not versioned, with breaking change this is un-usable for previous version

@ExpandingMan
Copy link
Collaborator

We've been trying to fix tagbot, but at this point I have no idea how to do that. It probably requires intervention from people who have more permissions than I do.

@ablaom
Copy link
Contributor

ablaom commented Dec 5, 2022

I'm not expert, but I do notice that the current TagBot.yml is missing a ssh key. (There is a token, but not ssh). See the bottom of this example from the TagBot docs:

name: TagBot
on:
  issue_comment:
    types:
      - created
  workflow_dispatch:
    inputs:
      lookback:
        default: 3
permissions:
  actions: read
  checks: read
  contents: write
  deployments: read
  issues: read
  discussions: read
  packages: read
  pages: read
  pull-requests: read
  repository-projects: read
  security-events: read
  statuses: read
jobs:
  TagBot:
    if: github.event_name == 'workflow_dispatch' || github.actor == 'JuliaTagBot'
    runs-on: ubuntu-latest
    steps:
      - uses: JuliaRegistries/TagBot@v1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          # Edit the following line to reflect the actual name of the GitHub Secret containing your private key
          ssh: ${{ secrets.DOCUMENTER_KEY }}
          # ssh: ${{ secrets.NAME_OF_MY_SSH_PRIVATE_KEY_SECRET }}

So if this is added, and someone with privileges adds a corresponding secret key in the repo Settings, then maybe that will fix this....

@Moelf
Copy link
Contributor Author

Moelf commented Dec 5, 2022

@aviks ?

@Moelf
Copy link
Contributor Author

Moelf commented Jan 10, 2023

bump

@aviks
Copy link
Collaborator

aviks commented Jan 17, 2023

@Moelf I now have as much privileges on this repo as @ExpandingMan.

I do not think adding this key is necessary. I don't add this to any of my personal repos, and it seems to work. Here's and example from a couple of weeks ago: Tagbot Run, Workflow file. You'll notice the run succeeded, and the workflow file does not have any ssh key defined. It only uses the default GITHUB_TOKEN

There have been long term reports about Tagbot being flakey in the past few months: JuliaRegistries/TagBot#242

@aviks
Copy link
Collaborator

aviks commented Jan 17, 2023

Also, it looks like the last Tagbot run succeeded, and v2.2.1 has been successfully tagged: https://github.com/dmlc/XGBoost.jl/releases/tag/v2.2.1

@Moelf Moelf closed this as completed Jan 17, 2023
@ExpandingMan
Copy link
Collaborator

Thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants