Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminating dot in the permissions' spelling #688

Closed
dilyanpalauzov opened this issue Jun 14, 2018 · 5 comments
Closed

Terminating dot in the permissions' spelling #688

dilyanpalauzov opened this issue Jun 14, 2018 · 5 comments

Comments

@dilyanpalauzov
Copy link

When DavDroid is installed, it asks for permissions to share information with OpenTasks with
Allow DavDroid to Create, modify and delete tasks and task lists.? Notice the weird fullstop before the question mark. This could help:

diff --git a/opentasks-provider/src/main/res/values/strings.xml b/opentasks-provider/src/main/res/values/strings.xml
--- a/opentasks-provider/src/main/res/values/strings.xml
+++ b/opentasks-provider/src/main/res/values/strings.xml
@@ -7,8 +7,8 @@
     <!-- Permissions -->
 
     <string name="opentasks_permission_read_tasks">read tasks</string>
-    <string name="opentasks_permission_description_read_tasks">Read tasks and task lists.</string>
+    <string name="opentasks_permission_description_read_tasks">Read tasks and task lists</string>
     <string name="opentasks_permission_write_tasks">write tasks</string>
-    <string name="opentasks_permission_description_write_tasks">Create, modify and delete tasks and task lists.</string>
+    <string name="opentasks_permission_description_write_tasks">Create, modify and delete tasks and task lists</string>
 
 </resources>
@dmfs
Copy link
Owner

dmfs commented Jun 18, 2018

Right. On older Android version there was no Question, because permissions were granted automatically at runtime, hence the full stop.
I guess is would also make sense to start with a lower case letter.
Would you care opening a pull request?

@dilyanpalauzov
Copy link
Author

I think for two bytes it is overengineering to run such a process.

@dmfs
Copy link
Owner

dmfs commented Jun 21, 2018

I disagree, I'd create a PR even for a single bit. It's not really a lot of overhead IMO. In the end it's probably comparable to what you did to open this ticket.
Anyway, I can also do it myself of course.

@dilyanpalauzov
Copy link
Author

Please take care of this.

@dmfs
Copy link
Owner

dmfs commented Sep 25, 2018

I've made this change in the course of #704. I had to add new descriptions and removing the dots in this commit felt like a good idea.

@dmfs dmfs closed this as completed in 822ac39 Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants