Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on Country at checkout page throws error "Error while updating property 'importantForAccessibility' of a view managed by: RCTView #128

Closed
Nahyan9798 opened this issue Apr 22, 2020 · 19 comments
Assignees
Labels
bug Something isn't working

Comments

@Nahyan9798
Copy link

Nahyan9798 commented Apr 22, 2020

Underneath it says "java.lang.boolean cannot be cast to java.lang.String"

It is a local magento 2.2.11 install and latest react native version,
I have seen your fix regarding 2 'ComponentDidMount' functions, it still does not fix this issue,

Expected behavior
It should show countries to select

Current Behavior
Currently, it gives red screen error as described above.

Steps to Reproduce

  1. add something to cart
  2. goto checkout page
  3. Enter account details, (also tried logging in and doing step 4.)
  4. click on country, it will throw error
    Screenshots
    If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Magento Version: 2.2.11
  • Device: Android Emulator running android 10
  • OS: Android Q
@dimaportenko
Copy link
Owner

@Nahyan9798 can share a stack trace of the error or attach a screenshot of the screen with error?

@Nahyan9798
Copy link
Author

Screenshot from 2020-04-22 14-57-26

Screenshot from 2020-04-22 14-08-59

This is the error when i touch country.

I would love to figure this error out but i am lost as to where i should start, thank you for replying so quickly

@dimaportenko
Copy link
Owner

@Nahyan9798 fixed. Please take a look.

@Nahyan9798
Copy link
Author

I made the changes to yarn.lock and packages.json as seen in the pr, but still the issue persists

@dimaportenko
Copy link
Owner

@Nahyan9798 did you install dependencies like npm install or yarn install ?

@Nahyan9798
Copy link
Author

Yes, Yes I did

@dimaportenko
Copy link
Owner

@Nahyan9798 I've just checked again. I can reproduce issue with old version of react-native-modal-selector and can't with new. Probably some cache issue on your end. Try remove the app from emulator and build it again.

@Nahyan9798
Copy link
Author

I tried deleting the app and building again, still the same issue, connected to physical device and installed but still issue persists,
if you could kindly suggest some things i could try to resolve the issue, i would be very thankful

@dimaportenko
Copy link
Owner

@Nahyan9798 check version in node_modules/react-native-modal-selector/package.json

@Nahyan9798
Copy link
Author

shows version 2.0.1

@Nahyan9798
Copy link
Author

Screenshot from 2020-04-22 19-24-22
there seems to be a problem here, bundleDependencies expects an array but is receiving just false, could this be the issue?

@Nahyan9798
Copy link
Author

nevermind this is the same for all dependencies, issue is something else

@dimaportenko
Copy link
Owner

@Nahyan9798 Looks like it is related to the data you pass to the modal selector, you can try to log it
Screenshot 2020-04-22 at 17 35 32

@dimaportenko
Copy link
Owner

I think also relates peacechen/react-native-modal-selector#143

@dimaportenko dimaportenko reopened this Apr 22, 2020
@Nahyan9798
Copy link
Author

It worked!
Changing these two parameters in node_modules/react-native-modal-selector/index.js from undefined to " " worked.
scrollViewAccessibilityLabel: "",
cancelButtonAccessibilityLabel: "",
Thank you for solving this issue!
On which countries does order button show up? i am selecting US and region as new york yet shipping address is not found for this selected address

Again Thanks a bunch for solving this issue.

@sanjeevyadavIT
Copy link
Collaborator

sanjeevyadavIT commented Apr 28, 2020

I think also relates peacechen/react-native-modal-selector#143

Hi @troublediehard I'm too having the same issue on my magento_react_native, bumped the react-native-modal-selector version, and working fine, do I have to do something else too apart from it, I didn't understand what else need to be set?

@dimaportenko
Copy link
Owner

hey @alexakasanjeev, I think after upgrade library it is still possible to reproduce this issue in some cases. But I don't dive into it a lot, so I'm going to keep this issue open for now.

@peacechen
Copy link

peacechen commented Jun 11, 2020

This has been fixed and published in react-native-modal-selector 2.0.2.

@dimaportenko
Copy link
Owner

@peacechen thank you for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants