Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix words endpoint for protected words #404

Closed
ztefanie opened this issue Oct 17, 2022 · 1 comment · Fixed by #405
Closed

Fix words endpoint for protected words #404

ztefanie opened this issue Oct 17, 2022 · 1 comment · Fixed by #405
Assignees
Labels
bug Something isn't working Prio:High

Comments

@ztefanie
Copy link
Member

ztefanie commented Oct 17, 2022

Describe the Bug

Requesting https://lunes-test.tuerantuer.org/api/words/1648 with correct api-key returns 404 Not Found.
Requesting https://lunes-test.tuerantuer.org/api/documents/248 with same api-key returns the word.

Expected Behavior

/words/:id-of-word should return the word also for protected vocabulary.

Actual Behavior

/words/:id-of-word returns 404 for protected vocabulary.

Additional Information

We need this feature for the app, as users can save vocabulary as favorites. We only save the id's and api-keys for favorites, so we cannot use the documents-endpoint, as we do not know the discipline-id of the word in this context.

@ztefanie ztefanie added the bug Something isn't working label Oct 17, 2022
@timobrembeck
Copy link
Member

I think this was a known caveat when implementing the feature, see #304.
Nevertheless it should be possible to add support for protected words without too much effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Prio:High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants