Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow runs on PR from other contributors #56

Closed
dickwolff opened this issue May 1, 2024 · 6 comments
Closed

Fix workflow runs on PR from other contributors #56

dickwolff opened this issue May 1, 2024 · 6 comments
Assignees
Labels
Bug Something isn't working

Comments

@dickwolff
Copy link
Owner

When a contributor opens a PR, the GitHub workflows do not run. I have to approve each run manually. When I run a workflow (eg. testing), the run fails on adding the test results on the PR:
image

The testing workflow needs to be able to run on any PR, and publish the results on the PR.

I don't want the Docker pipeline to run though, so not any image will be pushed to Docker hub.

@dickwolff dickwolff added the Bug Something isn't working label May 1, 2024
@dickwolff dickwolff mentioned this issue May 1, 2024
3 tasks
@dickwolff
Copy link
Owner Author

dickwolff commented May 1, 2024

Tried setting workflow permissions to r/w (as stated here, but still doesn't seem to work.

image

@dickwolff
Copy link
Owner Author

dickwolff commented May 2, 2024

As stated in this thread, changed pull_request to pull_request_target and now it works on forked repos!

Commit: 3edaa0f

@dickwolff dickwolff reopened this May 2, 2024
@dickwolff
Copy link
Owner Author

Did not solve the issue. Need to look into more.

@dickwolff
Copy link
Owner Author

Created a possible fix in #59 but will have to wait for someone else to open a PR to verify this.

@dickwolff dickwolff self-assigned this May 4, 2024
@dickwolff
Copy link
Owner Author

Still an issue. #67 failed with Resource not accessible

@dickwolff
Copy link
Owner Author

Reverted back to marocchino/sticky-pull-request-comment, but added check in step that only PR created by @dickwolff will add coverage. Not ideal but don't have a better solution. The tests run, which is the most important thing. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant