Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo shouldn't be used #71

Closed
onitake opened this issue Feb 13, 2017 · 3 comments
Closed

sudo shouldn't be used #71

onitake opened this issue Feb 13, 2017 · 3 comments

Comments

@onitake
Copy link

onitake commented Feb 13, 2017

Ansible warns about the sudo: yes flag in install.yml:

[DEPRECATION WARNING]: Instead of sudo/sudo_user, use become/become_user and make sure become_method is 'sudo' 
(default).
This feature will be removed in a future release.

I think it is safe to assume the haproxy role is run with superuser rights, so it doesn't make much sense to have the flag there.

@benwebber
Copy link
Collaborator

This is actually a deprecation warning. When Ansible 1.9 added new privilege escalation backends, they changed sudo to become. We simply need to rename the parameter.

@benwebber
Copy link
Collaborator

@onitake Sorry for misunderstanding your original point. Yes, the user should set become at the playbook level. The role shoudn't elevate permissions itself.

@onitake
Copy link
Author

onitake commented Apr 13, 2017

Sorry that I wasn't more clear, but thanks anyway! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants