Remove ALL existing code related to stored sponsors #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're moving to an entirely offline and manifest-based SL check, we don't need any of the complex stuff we had before. We just need a SINGLE endpoint to sign the JWT manifest sent by the gh-sponsors extension (see devlooped/gh-sponsors#8). Everything else is unnecessary now. The functionality is reduced but simplified significantly, with a massive improvement in PII/GDPR compliance. There is no longer any direct nor indirect telemetry tracked since the user must explicitly run a command and install an extension in their machine before getting a signed manifest. We also no longer provide a webhook for the GH apps, which will be deprecated too. Fixes #31
This was referenced Aug 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're moving to an entirely offline and manifest-based SL check, we don't need any of the complex stuff we had before. We just need a SINGLE endpoint to sign the JWT manifest sent by the gh-sponsors extension (see devlooped/gh-sponsors#8). Everything else is unnecessary now.
The functionality is reduced but simplified significantly, with a massive improvement in PII/GDPR compliance. There is no longer any direct nor indirect telemetry tracked since the user must explicitly run a command and install an extension in their machine before getting a signed manifest.
We also no longer provide a webhook for the GH apps, which will be deprecated too.
Fixes #31