Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown menu med fejl, kan overflow ind i chevron #255

Open
VirtualSatai opened this issue Nov 20, 2024 · 2 comments
Open

Dropdown menu med fejl, kan overflow ind i chevron #255

VirtualSatai opened this issue Nov 20, 2024 · 2 comments

Comments

@VirtualSatai
Copy link

Bekskriv fejlen (Describe the bug)

Hvis en dropdown har fejl ("form-error") så har feltet ikke korrekt padding-right, og derfor kan tekst overflowe forkert:
image

Det skyldes at reglen for form-error overskrifter padding:

.form-group.form-error>.form-input,
.form-group.form-error>.form-select,
.form-group.form-error>fieldset>.date-group .form-input,
.form-group.form-error>.date-picker .form-input,
.form-group.form-error>.form-input-wrapper>.form-input {
  border:2px solid #c00;
  padding:calc(8px - 2px) calc(16px - 2px)
}

Men ikke padding-right ordenligt på .form-select:

.form-select {
  /* ...*/
  padding:calc(8px - 1px) calc(16px - 1px);
  padding-right:32px;
  /* ...*/
}

Genskab fejlen (To Reproduce)

hav en dropdown mere længere indhold end der er plads, og lad den fejle validering.

Screenshots
image

Sådan burde det fungere (Expected behavior)
Der skal fortsat være padding-right selv ved fejl.

Desktop - udfyld venligst følgende (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone - udfyld venligst følgende (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Supplerende oplysninger (Additional context)

@VirtualSatai VirtualSatai changed the title Gør overskriften beskrivende (Add a descriptive title) Dropdown menu med fejl, kan overflow ind i chevron Nov 20, 2024
@detfaellesdesignsystem
Copy link
Owner

Hej @VirtualSatai Tak for din henvendelse.
Vi har oprettet en sag på det.

Med venlig hilsen
Det Fælles Designsystem

@detfaellesdesignsystem
Copy link
Owner

Hej @VirtualSatai

Fejlen er rettet i version 10.2.0.

Med venlig hilsen
Det Fælles Designsystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants