Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the time the notification is displayed #8

Closed
TheOneBehindYou opened this issue Jun 18, 2018 · 2 comments
Closed

Setting the time the notification is displayed #8

TheOneBehindYou opened this issue Jun 18, 2018 · 2 comments

Comments

@TheOneBehindYou
Copy link

Hi,
all is said in the title!
It could be nice to ad an option for the user to chose the amount of time the notification "cleared success" is displayed.
Thanks.

@dessant
Copy link
Owner

dessant commented Jun 18, 2018

Hi, this sounds reasonable, thanks for bringing it up! We also have the needed API: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/notifications/clear

Though I'd like to have a couple of predefined values that you can choose from, not an arbitrary number of seconds.

It would look something like this:

Clear notifications:

  • 4 seconds
  • 10 seconds
  • 30 seconds
  • Never

@dessant
Copy link
Owner

dessant commented May 16, 2019

After some more thinking, just removing the success notification after 6 seconds may be enough, I don't yet see a need to configure the success notification timeout, what's important is for it to be automatically removed. Error notifications will remain unchanged and stay in the notification feed until the user dismisses them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants