fix: reduce size of imported background code

dessant · Jan 3, 2018 · 7a83c56 · 7a83c56
1 parent 94c70ee
commit 7a83c56
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 20 deletions.
diff --git a/src/action/index.html b/src/action/index.html
@@ -14,7 +14,6 @@
 
     <script src="/src/manifest.bundle.js"></script>
     <script src="/src/vue.bundle.js"></script>
-    <script src="/src/commons.bundle.js"></script>
     <script src="/src/commons-ui/commons.bundle.js"></script>
     <script src="action.bundle.js"></script>
   </body>

diff --git a/src/background/index.html b/src/background/index.html
@@ -6,7 +6,6 @@
   <body>
 
     <script src="/src/manifest.bundle.js"></script>
-    <script src="/src/commons.bundle.js"></script>
     <script src="background.bundle.js"></script>
   </body>
 </html>
diff --git a/src/contribute/index.html b/src/contribute/index.html
@@ -13,7 +13,6 @@
 
     <script src="/src/manifest.bundle.js"></script>
     <script src="/src/vue.bundle.js"></script>
-    <script src="/src/commons.bundle.js"></script>
     <script src="/src/commons-ui/commons.bundle.js"></script>
     <script src="contribute.bundle.js"></script>
   </body>

diff --git a/src/options/index.html b/src/options/index.html
@@ -14,7 +14,6 @@
 
     <script src="/src/manifest.bundle.js"></script>
     <script src="/src/vue.bundle.js"></script>
-    <script src="/src/commons.bundle.js"></script>
     <script src="/src/commons-ui/commons.bundle.js"></script>
     <script src="options.bundle.js"></script>
   </body>

diff --git a/webpack.config.js b/webpack.config.js
@@ -8,7 +8,6 @@ const ExtractTextPlugin = require('extract-text-webpack-plugin');
 const targetEnv = process.env.TARGET_ENV || 'firefox';
 const isProduction = process.env.NODE_ENV === 'production';
 
-const uiModules = ['options', 'action', 'contribute'];
 let plugins = [
   new webpack.DefinePlugin({
     'process.env': {
@@ -27,21 +26,7 @@ let plugins = [
   new webpack.optimize.CommonsChunkPlugin({
     name: 'commons-ui',
     filename: '[name]/commons.bundle.js',
-    chunks: uiModules,
-    minChunks: function(module, count) {
-      return (
-        module.resource &&
-        /\/(@material|ext-(components|contribute)|(css|vue)-loader|src\/(options|action|contribute))\//.test(
-          module.resource
-        ) &&
-        count >= 2
-      );
-    }
-  }),
-  new webpack.optimize.CommonsChunkPlugin({
-    name: 'commons',
-    filename: '[name].bundle.js',
-    chunks: ['background', ...uiModules],
+    chunks: ['options', 'action', 'contribute'],
     minChunks: 2
   }),
   isProduction ? new webpack.optimize.ModuleConcatenationPlugin() : null,