From 4e5e500b953e7bb33c5619cdcee55670653590e3 Mon Sep 17 00:00:00 2001 From: dessant Date: Sat, 10 Mar 2018 15:30:52 +0200 Subject: [PATCH] fix: do not pass `since` when removing localStorage in Firefox --- src/background/main.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/background/main.js b/src/background/main.js index 4c700ac..2c83b3e 100644 --- a/src/background/main.js +++ b/src/background/main.js @@ -8,6 +8,7 @@ import { showContributePage } from 'utils/app'; import {optionKeys} from 'utils/data'; +import {targetEnv} from 'utils/config'; async function clearDataType(dataType, options, enDataTypes = null) { let {useCount} = await storage.get('useCount', 'sync'); @@ -61,7 +62,13 @@ async function clearDataType(dataType, options, enDataTypes = null) { } try { - await browser.browsingData.remove({since}, dataTypes); + if (dataTypes.localStorage && since && targetEnv === 'firefox') { + await browser.browsingData.removeLocalStorage({}); + delete dataTypes.localStorage; + } + if (Object.keys(dataTypes).length) { + await browser.browsingData.remove({since}, dataTypes); + } } catch (e) { console.log(e); await showNotification('error_dataTypeNotCleared');