Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish layout missing simbols #189

Closed
pygope opened this issue Apr 23, 2023 · 5 comments · Fixed by #209
Closed

Spanish layout missing simbols #189

pygope opened this issue Apr 23, 2023 · 5 comments · Fixed by #209
Labels
enhancement New feature or request

Comments

@pygope
Copy link

pygope commented Apr 23, 2023

  • [ x] Did you check to see if this issue already exists?
  • [x ] Is this only a single feature request? Do not put multiple feature requests in one issue.
  • [ x] Is this a question or discussion? Don't use this, use https://lemmy.ml/c/thumbkey

** Describe the feature request below **
In spanish, interrogations and exclamations have a beginning simbol besides the ending one (? !),
Those simbols are ¿ and ¡ respectively, and I miss them in your keyboard.

@pygope pygope added the enhancement New feature or request label Apr 23, 2023
@dessalines
Copy link
Owner

Feel free to edit those files directly.

@sodito
Copy link

sodito commented May 5, 2023

Spanish layout file ThumbKeyESv1 modified to add missing punctuation symbols (¿ and ¡) and letter ü (u-diaeresis). Following is the lines added to file ThumbKeyESv1.
character ¡ Lines 47-49 and Lines 284-286
character ü Lines 65-67 and Lines 302-304
character ¿ Lines 73-75 and Lines 310-312

ThumbKeyESv2.zip

``package com.dessalines.thumbkey.keyboards

import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.outlined.ArrowDropDown
import androidx.compose.material.icons.outlined.ArrowDropUp
import androidx.compose.material.icons.outlined.Copyright
import androidx.compose.material.icons.outlined.KeyboardCapslock
import com.dessalines.thumbkey.utils.ColorVariant
import com.dessalines.thumbkey.utils.FontSizeVariant
import com.dessalines.thumbkey.utils.KeyAction
import com.dessalines.thumbkey.utils.KeyC
import com.dessalines.thumbkey.utils.KeyDisplay
import com.dessalines.thumbkey.utils.KeyItemC
import com.dessalines.thumbkey.utils.KeyboardC
import com.dessalines.thumbkey.utils.KeyboardMode
import com.dessalines.thumbkey.utils.SwipeDirection

val THUMBKEY_ES_V2_MAIN = KeyboardC(
arrayOf(
arrayOf(
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("n"),
action = KeyAction.CommitText("n"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.BOTTOM_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("b"),
action = KeyAction.CommitText("b")
),
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("ñ"),
action = KeyAction.CommitText("ñ")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("l"),
action = KeyAction.CommitText("l"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("¡"),
action = KeyAction.CommitText("¡")
),
SwipeDirection.BOTTOM to KeyC(
display = KeyDisplay.TextDisplay("v"),
action = KeyAction.CommitText("v")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("o"),
action = KeyAction.CommitText("o"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.BOTTOM to KeyC(
display = KeyDisplay.TextDisplay("ü"),
action = KeyAction.CommitText("ü")
),
SwipeDirection.BOTTOM_LEFT to KeyC(
display = KeyDisplay.TextDisplay("u"),
action = KeyAction.CommitText("u")
),
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("¿"),
action = KeyAction.CommitText("¿")
),
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("ó"),
action = KeyAction.CommitText("ó")
),
SwipeDirection.BOTTOM_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("ú"),
action = KeyAction.CommitText("ú")
)
)
),
SETTINGS_KEY_ITEM
),
arrayOf(
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("r"),
action = KeyAction.CommitText("r"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("p"),
action = KeyAction.CommitText("p")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("d"),
action = KeyAction.CommitText("d"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.TOP_LEFT to KeyC(
display = KeyDisplay.TextDisplay("j"),
action = KeyAction.CommitText("j")
),
SwipeDirection.TOP to KeyC(
display = KeyDisplay.TextDisplay("k"),
action = KeyAction.CommitText("k")
),
SwipeDirection.TOP_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("h"),
action = KeyAction.CommitText("h")
),
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("q"),
action = KeyAction.CommitText("q")
),
SwipeDirection.BOTTOM_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("y"),
action = KeyAction.CommitText("y")
),
SwipeDirection.BOTTOM to KeyC(
display = KeyDisplay.TextDisplay("x"),
action = KeyAction.CommitText("x")
),
SwipeDirection.BOTTOM_LEFT to KeyC(
display = KeyDisplay.TextDisplay("f"),
action = KeyAction.CommitText("f")
),
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("z"),
action = KeyAction.CommitText("z")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("a"),
action = KeyAction.CommitText("a"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("t"),
action = KeyAction.CommitText("t")
),
SwipeDirection.TOP to KeyC(
display = KeyDisplay.IconDisplay(Icons.Outlined.ArrowDropUp),
action = KeyAction.ToggleShiftMode(true),
color = ColorVariant.MUTED
),
SwipeDirection.BOTTOM_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("á"),
action = KeyAction.CommitText("á")
)
)
),
NUMERIC_KEY_ITEM
),
arrayOf(
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("s"),
action = KeyAction.CommitText("s"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.TOP_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("m"),
action = KeyAction.CommitText("m")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("i"),
action = KeyAction.CommitText("i"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.TOP to KeyC(
display = KeyDisplay.TextDisplay("g"),
action = KeyAction.CommitText("g")
),
SwipeDirection.TOP_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("'"),
action = KeyAction.CommitText("'"),
color = ColorVariant.MUTED
),
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("í"),
action = KeyAction.CommitText("í")
),
SwipeDirection.BOTTOM_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("-"),
action = KeyAction.CommitText("-"),
color = ColorVariant.MUTED
),
SwipeDirection.BOTTOM to KeyC(
display = KeyDisplay.TextDisplay("."),
action = KeyAction.CommitText("."),
color = ColorVariant.MUTED
),
SwipeDirection.BOTTOM_LEFT to KeyC(
display = KeyDisplay.TextDisplay(""),
action = KeyAction.CommitText("
"),
color = ColorVariant.MUTED
),
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("w"),
action = KeyAction.CommitText("w")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("e"),
action = KeyAction.CommitText("e"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.TOP_LEFT to KeyC(
display = KeyDisplay.TextDisplay("c"),
action = KeyAction.CommitText("c")
),
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("é"),
action = KeyAction.CommitText("é")
)
)
),
BACKSPACE_KEY_ITEM
),
arrayOf(
SPACEBAR_KEY_ITEM,
RETURN_KEY_ITEM
)
)
)

val THUMBKEY_ES_V2_SHIFTED = KeyboardC(
arrayOf(
arrayOf(
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("N"),
action = KeyAction.CommitText("N"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.BOTTOM_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("B"),
action = KeyAction.CommitText("B")
),
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("Ñ"),
action = KeyAction.CommitText("Ñ")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("L"),
action = KeyAction.CommitText("L"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("¡"),
action = KeyAction.CommitText("¡")
),
SwipeDirection.BOTTOM to KeyC(
display = KeyDisplay.TextDisplay("V"),
action = KeyAction.CommitText("V")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("O"),
action = KeyAction.CommitText("O"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.BOTTOM to KeyC(
display = KeyDisplay.TextDisplay("ü"),
action = KeyAction.CommitText("ü")
),
SwipeDirection.BOTTOM_LEFT to KeyC(
display = KeyDisplay.TextDisplay("U"),
action = KeyAction.CommitText("U")
),
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("¿"),
action = KeyAction.CommitText("¿")
),
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("Ó"),
action = KeyAction.CommitText("Ó")
),
SwipeDirection.BOTTOM_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("Ú"),
action = KeyAction.CommitText("Ú")
)
)
),
SETTINGS_KEY_ITEM
),
arrayOf(
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("R"),
action = KeyAction.CommitText("R"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("P"),
action = KeyAction.CommitText("P")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("D"),
action = KeyAction.CommitText("D"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.TOP_LEFT to KeyC(
display = KeyDisplay.TextDisplay("J"),
action = KeyAction.CommitText("J")
),
SwipeDirection.TOP to KeyC(
display = KeyDisplay.TextDisplay("K"),
action = KeyAction.CommitText("K")
),
SwipeDirection.TOP_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("H"),
action = KeyAction.CommitText("H")
),
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("Q"),
action = KeyAction.CommitText("Q")
),
SwipeDirection.BOTTOM_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("Y"),
action = KeyAction.CommitText("Y")
),
SwipeDirection.BOTTOM to KeyC(
display = KeyDisplay.TextDisplay("X"),
action = KeyAction.CommitText("X")
),
SwipeDirection.BOTTOM_LEFT to KeyC(
display = KeyDisplay.TextDisplay("F"),
action = KeyAction.CommitText("F")
),
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("Z"),
action = KeyAction.CommitText("Z")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("A"),
action = KeyAction.CommitText("A"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("T"),
action = KeyAction.CommitText("T")
),
SwipeDirection.BOTTOM to KeyC(
display = KeyDisplay.IconDisplay(Icons.Outlined.ArrowDropDown),
action = KeyAction.ToggleShiftMode(false),
color = ColorVariant.MUTED
),
SwipeDirection.TOP to KeyC(
display = KeyDisplay.IconDisplay(Icons.Outlined.KeyboardCapslock),
capsModeDisplay = KeyDisplay.IconDisplay(Icons.Outlined.Copyright),
action = KeyAction.ToggleCapsLock,
color = ColorVariant.MUTED
),
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("Á"),
action = KeyAction.CommitText("Á")
)
)
),
NUMERIC_KEY_ITEM
),
arrayOf(
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("S"),
action = KeyAction.CommitText("S"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.TOP_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("M"),
action = KeyAction.CommitText("M")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("I"),
action = KeyAction.CommitText("I"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.TOP to KeyC(
display = KeyDisplay.TextDisplay("G"),
action = KeyAction.CommitText("G")
),
SwipeDirection.TOP_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("'"),
action = KeyAction.CommitText("'"),
color = ColorVariant.MUTED
),
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("Í"),
action = KeyAction.CommitText("Í")
),
SwipeDirection.BOTTOM_RIGHT to KeyC(
display = KeyDisplay.TextDisplay("-"),
action = KeyAction.CommitText("-"),
color = ColorVariant.MUTED
),
SwipeDirection.BOTTOM to KeyC(
display = KeyDisplay.TextDisplay("."),
action = KeyAction.CommitText("."),
color = ColorVariant.MUTED
),
SwipeDirection.BOTTOM_LEFT to KeyC(
display = KeyDisplay.TextDisplay(""),
action = KeyAction.CommitText("
"),
color = ColorVariant.MUTED
),
SwipeDirection.LEFT to KeyC(
display = KeyDisplay.TextDisplay("W"),
action = KeyAction.CommitText("W")
)
)
),
KeyItemC(
center = KeyC(
display = KeyDisplay.TextDisplay("E"),
action = KeyAction.CommitText("E"),
size = FontSizeVariant.LARGE,
color = ColorVariant.PRIMARY
),
swipes = mapOf(
SwipeDirection.TOP_LEFT to KeyC(
display = KeyDisplay.TextDisplay("C"),
action = KeyAction.CommitText("C")
),
SwipeDirection.RIGHT to KeyC(
display = KeyDisplay.TextDisplay("É"),
action = KeyAction.CommitText("É")
)
)
),
BACKSPACE_KEY_ITEM
),
arrayOf(
SPACEBAR_KEY_ITEM,
RETURN_KEY_ITEM
)
)
)

val THUMBKEY_ES_V2_KEYBOARD_MODES: Map<KeyboardMode, KeyboardC> = mapOf(
KeyboardMode.MAIN to THUMBKEY_ES_V2_MAIN,
KeyboardMode.SHIFTED to THUMBKEY_ES_V2_SHIFTED,
KeyboardMode.NUMERIC to NUMERIC_KEYBOARD
)

@dessalines
Copy link
Owner

Edit / do a PR to that file manually.

@sodito
Copy link

sodito commented May 5, 2023

Sorry, I am new to this I don't know how to compile or edit that file in a device the app is installed. I hope you can incorporate the changes I made above on your next release. By the way, this is a very ingenious and nice app. I'll be supporting your effort somehow if it gets updated. Thank you very much!

@mpice-mn mpice-mn mentioned this issue May 5, 2023
@mpice-mn
Copy link
Contributor

mpice-mn commented May 5, 2023

@sodito: I've testet your changes on my device and created a pull request. Maybe edit your comment above and remove the kotlin code since it only clutters up this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants