Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Table with UXPin #1053

Closed
scurker opened this issue May 2, 2023 · 1 comment
Closed

Sync Table with UXPin #1053

scurker opened this issue May 2, 2023 · 1 comment
Assignees

Comments

@scurker
Copy link
Member

scurker commented May 2, 2023

Changes:

  • Thicker border between TableHeader / TableBody (vertical and horizontal) for bordered variant
  • Fix the sizing of the sort iconography (when sorted, the icon is slightly displaced)
  • For sortable table headers, change the icon from space-between to flex-start
  • Update sort up / down icon so it's not as large and matches UXPin
  • Add a note to documentation to recommend that authors indicate the current sorted column by default:
    • As a best practice, when a table has sorted columns an author should indicate which column is currently sorted by setting the sort direction for the active sorted column.

UXPin Design System: https://app.uxpin.com/design-system/c933c74928e2195cc540/ui-patterns/213536

@bobbyomari
Copy link
Contributor

bobbyomari commented Aug 16, 2023

This has been completed and is part of #1154

@scurker scurker closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants