Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<aside> aria-labelledby a child <header> does not make it a unique landmark #2236

Closed
gretencord opened this issue May 15, 2020 · 3 comments
Closed
Assignees
Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Milestone

Comments

@gretencord
Copy link

Expectation: <aside> labeled by child <header> should pass. This fails:

<aside aria-labelledby="header-1">
  <header id="header-1">Header 1</header>
</aside>
<aside aria-labelledby="header-2">
  <header id="header-2">Header 2</header>
</aside>

Replacing <header> with <div> or <aside> with <section> passes. Using aria-label="something" instead of aria-labelledby also passes.

Actual: landmark-unique rule is thrown: "Landmarks must have a unique role or role/label/title (i.e. accessible name) combination"

Motivation: The issue appears to be with the <header> tag. From what I understand "The header element is not a banner landmark when it is a descendant of ... HTML sectioning elements" including <aside> source. Regardless, I'm not sure why aXe will not accept it as the referenced label for its parent <aside>.


axe-core version: 3.5.3
axe-webdriver, extension or other integration version: Web Accessibility Testing Chrome Extension 4.5.0

Browser and Assistive Technology versions: Windows 10 Chrome 81
@WilcoFiers
Copy link
Contributor

WilcoFiers commented May 18, 2020

Jup, you seem to be right. The issue is that axe-core still treats these header elements as landmarks; it shouldn't because they are a descendent of an aside element.

Fixing this is going to require an overhaul of our implicit role computation. That's been over due for a while so we'll try to get it prioritised for the 4.0 release in August.

@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule labels May 18, 2020
@WilcoFiers WilcoFiers added this to the Axe-core 4.0 milestone May 18, 2020
@straker straker self-assigned this May 20, 2020
@padmavemulapati
Copy link

Verified with axe-core3.5.5 , <aside> aria-labelledby ..<header> is not failing now and showing it in passes. Attached the screenshots describing passes and also voilations list(not having <aside>)
image
image

@jeankaplansky
Copy link
Contributor

no rule-help changes required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

5 participants