-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the "axeVersion" property for axe.configure for compatibility #1780
Comments
Why "ver"? It's not a word. |
See update above, renamed |
Corresponding Comply ticket to accommodate this change: Accommodate axe 3.4 version-compatibility checking |
I've updated the above example to include canary versions. |
Added to axe-core 3.4 release notes on 9/12. |
@straker what needs to be QA here?? Can you please provide the required steps. |
Just that setting different |
@chandana7393 steps to verify this ticket:
Expected: You should see a meaningful error. @WilcoFiers Can you please confirm these steps are correct and provide an example custom rule that contains axe.configure |
Comment from @WilcoFiers : You can’t verify this with the Attest extension. You’ll need to download axe-core@next from NPM, include it in any of the Attest APIs, (or axe-cli) and try to pass it a custom ruleset with an axeVersion set that’s incompatible. @padmavemulapati See if you can verify this ticket. |
@padmavemulapati This ticket is in "ReadyForQA" for a long time. Please verify asap. |
Installed different axe versions with Node's get() , and apply in the APIs 'configure - obviously lower versions are incompatible and higher versions are compatible. |
When calling
axe.configure()
with a "axeVersion" property, axe-core should check if that version of the custom rule is compatible with the axe-core version that's used. Custom rules are compatible with all patch and minor updates that are the same as, or newer than those in "axeVersion". So:If axe.configure is called with an incompatible version, axe-core should throw a meaningful error.
Edit: The
ver
property has been renamed toaxeVersion
. We will add support forver
, but have it only be available as a deprecated feature, that will be removed as of the next major release.The text was updated successfully, but these errors were encountered: