From b524ea954fdcf8fcf09b49bdbe546335ed0e46df Mon Sep 17 00:00:00 2001
From: Steven Lambert <2433219+straker@users.noreply.github.com>
Date: Thu, 18 Jun 2020 10:58:44 -0600
Subject: [PATCH] fix(aria-allowed-role): allow role=presentation on hr (#2300)

* fix(aria-allowed-role): allow role=presentation on hr

* add test
---
 lib/commons/aria/lookup-table.js                              | 2 ++
 .../rules/aria-allowed-role/aria-allowed-role.html            | 2 ++
 .../rules/aria-allowed-role/aria-allowed-role.json            | 4 +++-
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/lib/commons/aria/lookup-table.js b/lib/commons/aria/lookup-table.js
index f44ece642c..754cca91b6 100644
--- a/lib/commons/aria/lookup-table.js
+++ b/lib/commons/aria/lookup-table.js
@@ -1429,6 +1429,7 @@ lookupTable.role = {
 					'h5',
 					'h6',
 					'header',
+					'hr',
 					'iframe',
 					'li',
 					'ol',
@@ -1515,6 +1516,7 @@ lookupTable.role = {
 					'h5',
 					'h6',
 					'header',
+					'hr',
 					'iframe',
 					'li',
 					'ol',
diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.html b/test/integration/rules/aria-allowed-role/aria-allowed-role.html
index 1ce0ea43d1..243ab26185 100644
--- a/test/integration/rules/aria-allowed-role/aria-allowed-role.html
+++ b/test/integration/rules/aria-allowed-role/aria-allowed-role.html
@@ -167,6 +167,8 @@ <h1 id="pass-h1-valid-role" role="none"></h1>
 <ul>
 	<li id="pass-dpub-7" role="doc-endnote">ok</li>
 </ul>
+<hr id="hr-presentation" role="presentation" />
+<hr id="hr-none" role="none" />
 
 <dd id="fail-dd-no-role" role="link"></dd>
 <dt id="fail-dt-no-role" role="banner"></dt>
diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.json b/test/integration/rules/aria-allowed-role/aria-allowed-role.json
index 37de3d97a3..feefed99c2 100644
--- a/test/integration/rules/aria-allowed-role/aria-allowed-role.json
+++ b/test/integration/rules/aria-allowed-role/aria-allowed-role.json
@@ -64,7 +64,9 @@
 		["#pass-dpub-4"],
 		["#pass-dpub-5"],
 		["#pass-dpub-6"],
-		["#pass-dpub-7"]
+		["#pass-dpub-7"],
+		["#hr-presentation"],
+		["#hr-none"]
 	],
 	"violations": [
 		["#fail-dd-no-role"],