fix(aria-required-attr): don't require aria-valuemin/max (#1529)

* fix(aria-required-attr): don't require aria-valuemin/max * fix failing test
dequelabs · May 9, 2019 · 80ae444 · 80ae444
1 parent 1b507b3
commit 80ae444
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 16 deletions.
diff --git a/lib/commons/aria/index.js b/lib/commons/aria/index.js
@@ -1682,13 +1682,14 @@ lookupTable.role = {
 	scrollbar: {
 		type: 'widget',
 		attributes: {
-			required: [
-				'aria-controls',
-				'aria-valuenow',
+			required: ['aria-controls', 'aria-valuenow'],
+			allowed: [
+				'aria-valuetext',
+				'aria-orientation',
+				'aria-errormessage',
 				'aria-valuemax',
 				'aria-valuemin'
-			],
-			allowed: ['aria-valuetext', 'aria-orientation', 'aria-errormessage']
+			]
 		},
 		owned: null,
 		nameFrom: ['author'],
@@ -1775,9 +1776,11 @@ lookupTable.role = {
 				'aria-valuetext',
 				'aria-orientation',
 				'aria-readonly',
-				'aria-errormessage'
+				'aria-errormessage',
+				'aria-valuemax',
+				'aria-valuemin'
 			],
-			required: ['aria-valuenow', 'aria-valuemax', 'aria-valuemin']
+			required: ['aria-valuenow']
 		},
 		owned: null,
 		nameFrom: ['author'],
@@ -1792,9 +1795,11 @@ lookupTable.role = {
 				'aria-valuetext',
 				'aria-required',
 				'aria-readonly',
-				'aria-errormessage'
+				'aria-errormessage',
+				'aria-valuemax',
+				'aria-valuemin'
 			],
-			required: ['aria-valuenow', 'aria-valuemax', 'aria-valuemin']
+			required: ['aria-valuenow']
 		},
 		owned: null,
 		nameFrom: ['author'],

diff --git a/test/checks/aria/required-attr.js b/test/checks/aria/required-attr.js
@@ -19,11 +19,7 @@ describe('aria-required-attr', function() {
 		assert.isFalse(
 			checks['aria-required-attr'].evaluate.call(checkContext, node)
 		);
-		assert.deepEqual(checkContext._data, [
-			'aria-valuenow',
-			'aria-valuemax',
-			'aria-valuemin'
-		]);
+		assert.deepEqual(checkContext._data, ['aria-valuenow']);
 	});
 
 	it('should return true if there is no role', function() {

diff --git a/test/integration/full/configure-options/configure-options.js b/test/integration/full/configure-options/configure-options.js
@@ -58,8 +58,6 @@ describe('Configure Options', function() {
 					function(error, results) {
 						assert.lengthOf(results.violations, 1, 'violations');
 						assert.sameMembers(results.violations[0].nodes[0].any[0].data, [
-							'aria-valuemax',
-							'aria-valuemin',
 							'aria-snuggles'
 						]);
 						done();