From 6076ee8a7ba7527c9886916db1eda5d90cd26259 Mon Sep 17 00:00:00 2001
From: Maruthi Mohan <19310076+maruthimohan@users.noreply.github.com>
Date: Thu, 21 Oct 2021 07:32:07 -0400
Subject: [PATCH] fix(autocomplete-valid): Allow custom autocomplete attribute
 values (#3225)

---
 lib/checks/forms/autocomplete-valid.json              | 11 +++++++++++
 .../rules/autocomplete-valid/autocomplete-valid.html  |  9 +++++++++
 .../rules/autocomplete-valid/autocomplete-valid.json  |  9 ++++++++-
 3 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/lib/checks/forms/autocomplete-valid.json b/lib/checks/forms/autocomplete-valid.json
index c70c31fe79..0906e4b89a 100644
--- a/lib/checks/forms/autocomplete-valid.json
+++ b/lib/checks/forms/autocomplete-valid.json
@@ -7,5 +7,16 @@
       "pass": "the autocomplete attribute is correctly formatted",
       "fail": "the autocomplete attribute is incorrectly formatted"
     }
+  },
+  "options": {
+    "stateTerms": [
+      "none",
+      "false",
+      "true",
+      "disabled",
+      "enabled",
+      "undefined",
+      "null"
+    ]
   }
 }
diff --git a/test/integration/rules/autocomplete-valid/autocomplete-valid.html b/test/integration/rules/autocomplete-valid/autocomplete-valid.html
index 105d06128b..e38a7798ab 100644
--- a/test/integration/rules/autocomplete-valid/autocomplete-valid.html
+++ b/test/integration/rules/autocomplete-valid/autocomplete-valid.html
@@ -152,3 +152,12 @@
 <input autocomplete="cc-exp-month" type="tel" id="pass80" />
 <input autocomplete="cc-exp-year" type="tel" id="pass81" />
 <input autocomplete="cc-csc" type="tel" id="pass82" />
+
+<!-- Attribute values that contains synonyms of on/off -->
+<input autocomplete="none" id="pass84" />
+<input autocomplete="false" id="pass85" />
+<input autocomplete="true" id="pass86" />
+<input autocomplete="disabled" id="pass87" />
+<input autocomplete="enabled" id="pass88" />
+<input autocomplete="undefined" id="pass89" />
+<input autocomplete="null" id="pass90" />
diff --git a/test/integration/rules/autocomplete-valid/autocomplete-valid.json b/test/integration/rules/autocomplete-valid/autocomplete-valid.json
index fafa4cc824..b4eceb2603 100644
--- a/test/integration/rules/autocomplete-valid/autocomplete-valid.json
+++ b/test/integration/rules/autocomplete-valid/autocomplete-valid.json
@@ -85,6 +85,13 @@
     ["#pass80"],
     ["#pass81"],
     ["#pass82"],
-    ["#pass83"]
+    ["#pass83"],
+    ["#pass84"],
+    ["#pass85"],
+    ["#pass86"],
+    ["#pass87"],
+    ["#pass88"],
+    ["#pass89"],
+    ["#pass90"]
   ]
 }