From 1d3c2fc28355c8476d3966d73664a2a1f4c6124d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristoffer=20Nordstr=C3=B6m?= Date: Wed, 19 Aug 2020 23:40:07 +0200 Subject: [PATCH] fix(label): pass when role none or presentation (#2464) Pass label rule when role none or presentation Closes #2458 --- lib/rules/label.json | 4 +++- test/integration/rules/label/label.html | 3 +++ test/integration/rules/label/label.json | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/rules/label.json b/lib/rules/label.json index 9f1a6880f2..553f506659 100644 --- a/lib/rules/label.json +++ b/lib/rules/label.json @@ -20,7 +20,9 @@ "aria-labelledby", "implicit-label", "explicit-label", - "non-empty-title" + "non-empty-title", + "role-none", + "role-presentation" ], "none": ["help-same-as-label", "hidden-explicit-label"] } diff --git a/test/integration/rules/label/label.html b/test/integration/rules/label/label.html index 7a74d7a311..801d1a866d 100644 --- a/test/integration/rules/label/label.html +++ b/test/integration/rules/label/label.html @@ -73,4 +73,7 @@ + + + diff --git a/test/integration/rules/label/label.json b/test/integration/rules/label/label.json index 5f42632f17..d33197ff1b 100644 --- a/test/integration/rules/label/label.json +++ b/test/integration/rules/label/label.json @@ -35,6 +35,8 @@ ["#pass13"], ["#pass14"], ["#pass15"], + ["#pass16"], + ["#pass17"], ["#pass-gh1176"] ] }