Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release-tests): new package to test releases went out correctly #408

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

WilcoFiers
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2021

CLA assistant check
All committers have signed the CLA.

@WilcoFiers WilcoFiers marked this pull request as draft November 30, 2021 12:04
@WilcoFiers WilcoFiers marked this pull request as ready for review November 30, 2021 13:14
@nloding
Copy link

nloding commented Nov 30, 2021

I am unclear on the intention for this package. Is it testing to make sure the latest release went out, or that whatever is latest is working? It's definitely testing the latter, but seems like it should really be testing the former?

@WilcoFiers
Copy link
Contributor Author

Both; Test that the release we just did went out, and that it can be installed and run without errors.

@nloding
Copy link

nloding commented Dec 1, 2021

OK, I think I was expecting to see a test along these lines:

const playwright = require('playwright');
const { default: AxeBuilder } = require('@axe-core/playwright');
const { version } = require('@axe-core/playwright/package.json');
const { version: releaseVersion } = require('../package.json')

describe(`@axe-core/playwright v${version}`, () => {
  it('has the right version', async () => {
    assertEqual(version, releaseVersion)
  });
});

After the release runs, the version should be bumped on this package, and if we keep them in sync ...

Would this not work?

@WilcoFiers
Copy link
Contributor Author

No, the version in the package.json root is just 1.0.0. But I suppose we could pull out each package.json file from packages and compare it to that. That'd do it.

Copy link

@nloding nloding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@WilcoFiers WilcoFiers merged commit 50e6839 into develop Dec 9, 2021
@WilcoFiers WilcoFiers deleted the release-test branch December 9, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants